build: Install missing dependencies #1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This has been tested in docker's debian:stable image Also removing hardcoded Pi user as it could support other id (even root), or other target device. Bug: WebThingsIO#1206 Change-Id: I537ad8c8c3a3b4af161b61a7968073f4d3b7cee1 Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
rzr force-pushed the sandbox/rzr/review/fix/master branch from 5d1266d to e73f763 Compare 
Codecov Report
@@ Coverage Diff @@ ## master #1206 +/- ## ======================================= Coverage 77.62% 77.62% ======================================= Files 116 116 Lines 5662 5662 Branches 790 790 ======================================= Hits 4395 4395 Misses 1127 1127 Partials 140 140Continue to review full report at Codecov.
|
rzr added a commit to TizenTeam/gateway that referenced this pull request Jul 23, 2018
This has been tested in docker's debian:stable image Also removing hardcoded Pi user as it could support other id (even root), or other target device. Bug: WebThingsIO#1206 Change-Id: I537ad8c8c3a3b4af161b61a7968073f4d3b7cee1 Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
rzr added a commit to TizenTeam/gateway that referenced this pull request Jul 25, 2018
This has been tested in docker's debian:stable image Also removing hardcoded Pi user as it could support other id (even root), or other target device. Bug: WebThingsIO#1206 Change-Id: I537ad8c8c3a3b4af161b61a7968073f4d3b7cee1 Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
rzr added a commit to TizenTeam/gateway that referenced this pull request Jul 26, 2018
This has been tested in docker's debian:stable image Also removing hardcoded Pi user as it could support other id (even root), or other target device. Bug: WebThingsIO#1206 Change-Id: I537ad8c8c3a3b4af161b61a7968073f4d3b7cee1 Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Contributor Author
| Once this file is merged I will share a docker file to run gw in a container. |
Contributor
| @rzr We've already got a Docker image, will yours do anything different? |
Contributor Author
| Oh you made that too, well mine is just testing the gateway on raspbian (using qemu binfmt), https://github.com/TizenTeam/gateway/blob/sandbox/rzr/devel/master/Dockerfile maybe both can be used in different use cases Anyway this change is safe to merge: |
rzr added a commit to TizenTeam/gateway that referenced this pull request Aug 4, 2018
This has been tested in docker's debian:stable image Also removing hardcoded Pi user as it could support other id (even root), or other target device. Bug: WebThingsIO#1206 Change-Id: I537ad8c8c3a3b4af161b61a7968073f4d3b7cee1 Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Contributor Author
| FYI this change will help to get support of gateway on ARTIK7, (this should also help for ARTIK5 or ARTIK10) |
hobinjk approved these changes Aug 7, 2018
Contributor
hobinjk left a comment
hobinjk left a comment There was a problem hiding this comment.
LGTM based on running install.sh on raspbian
ghost removed the rzr added a commit to TizenTeam/gateway that referenced this pull request Aug 21, 2018
This has been tested in docker's debian:stable image Also removing hardcoded Pi user as it could support other id (even root), or other target device. Bug: WebThingsIO#1206 Change-Id: I537ad8c8c3a3b4af161b61a7968073f4d3b7cee1 Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This has been tested in docker's debian:stable image
Also removing hardcoded Pi user as it could support other id (even root),
or other target device.
Change-Id: I537ad8c8c3a3b4af161b61a7968073f4d3b7cee1
Signed-off-by: Philippe Coval philippe.coval@osg.samsung.com