Skip to content

Commit 9e9b05f

Browse files
committed
Refactoring, Method-Visibility changes
1 parent 43b1715 commit 9e9b05f

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

src/main/java/de/moritzf/sorting/logic/sorting/HeapSort.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public HeapSort(int[] input, boolean maxHeap) {
4141
protocol.add(new HeapStep(root, new ArrayList<>(), heapifyStartPosition));
4242
}
4343

44-
public void heapify(TreeNode<HeapSortNodeValue> elementToHeapify) {
44+
private void heapify(TreeNode<HeapSortNodeValue> elementToHeapify) {
4545
List<TreeNode<HeapSortNodeValue>> children = elementToHeapify.getChildren();
4646
Collections.sort(children, new HeapNodeComparator());
4747
int valueElement = elementToHeapify.getValue().getNumber();
@@ -57,8 +57,8 @@ public void heapify(TreeNode<HeapSortNodeValue> elementToHeapify) {
5757
doSwap = valueChild < valueElement;
5858
}
5959
if (doSwap) {
60-
elementToHeapify.getValue().setNumber(valueChild);
61-
children.get(0).getValue().setNumber(valueElement);
60+
elementToHeapify.getValue().replaceNumber(valueChild);
61+
children.get(0).getValue().replaceNumber(valueElement);
6262
heapify(children.get(0));
6363
}
6464
}
@@ -115,14 +115,14 @@ public boolean doStep() {
115115
return stepDone;
116116
}
117117

118-
public TreeNode<HeapSortNodeValue> createNewTree(TreeNode<HeapSortNodeValue> oldTree) {
118+
private TreeNode<HeapSortNodeValue> createNewTree(TreeNode<HeapSortNodeValue> oldTree) {
119119
TreeNode<HeapSortNodeValue> newTree =
120120
new TreeNode<>(new HeapSortNodeValue(oldTree.getValue().getNumber()));
121121
copyChildren(newTree, oldTree);
122122
return newTree;
123123
}
124124

125-
public void copyChildren(
125+
private void copyChildren(
126126
TreeNode<HeapSortNodeValue> newTreeNode, TreeNode<HeapSortNodeValue> oldTreeNode) {
127127
for (TreeNode<HeapSortNodeValue> oldChild : oldTreeNode.getChildren()) {
128128
TreeNode<HeapSortNodeValue> newChild =

src/main/java/de/moritzf/sorting/logic/sorting/HeapSortNodeValue.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public int getNumber() {
1515
return numbers.get(numbers.size() - 1);
1616
}
1717

18-
public void setNumber(int number) {
18+
public void replaceNumber(int number) {
1919
this.numbers.add(number);
2020
}
2121

src/main/java/de/moritzf/sorting/logic/sorting/HeapStep.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,4 @@ public List<Integer> getSortedNumbers() {
2727
return null;
2828
}
2929
}
30-
31-
public void setSortedNumbers(List<Integer> sortedNumbers) {
32-
this.sortedNumbers = sortedNumbers;
33-
}
3430
}

0 commit comments

Comments
 (0)