fix(NODE-5720): on pre-4.4 sharded servers, the node driver uses error.writeConcern.code to determine retryability #4155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
aditi-khare-mongoDB force-pushed the NODE-5720/clarify-retryable-fields branch 2 times, most recently from fb7495d to dcef868 Compare 
baileympearson added the Primary Review 
test/integration/retryable-writes/retryable_writes.spec.test.ts Outdated Show resolved Hide resolved
baileympearson requested changes Jul 1, 2024
test/integration/retryable-writes/retryable_writes.spec.test.ts Outdated Show resolved Hide resolved
aditi-khare-mongoDB changed the title aditi-khare-mongoDB changed the title WriteConcernError.code to determine retryability aditi-khare-mongoDB changed the title WriteConcernError.code to determine retryabilityWriteConcernError.code to add RetryableWriteLabel aditi-khare-mongoDB changed the title WriteConcernError.code to add RetryableWriteLabelWriteConcernError.code to determine retryability aditi-khare-mongoDB force-pushed the NODE-5720/clarify-retryable-fields branch from 25a4196 to 231fb80 Compare aditi-khare-mongoDB changed the title WriteConcernError.code to determine retryabilityWriteConcernError.code to determine retryability 
This was referenced Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
On pre-4.4
Mongosservers, no longer add aRetryableWriteLabeltoWriteConcernErrordue to itscodeproperty.What is changing?
Sync some retryable write spec tests and adhere to spec guidelines.
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
Spec compliance.
Release Highlight
Fix retryability criteria for write concern errors on pre-4.4 sharded clusters
Previously, the driver would erroneously retry writes on pre-4.4 sharded clusters based on a nested code in the server response (error.result.writeConcernError.code). Per the common drivers specification, retryability should be based on the top-level code (error.code). With this fix, the driver avoids unnecessary retries.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript