Skip to content

feat(NODE-5762): include cause and package name for all MongoMissingDependencyErrors #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 5, 2024
Merged

feat(NODE-5762): include cause and package name for all MongoMissingDependencyErrors #4067

merged 6 commits into from
Apr 5, 2024

Conversation

@baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Apr 3, 2024 •
edited
Loading

Description

What is changing?

MongoMissingDependencyError now includes two required properties:

  • dependencyName - the name of the missing dependency
  • cause - the error thrown when attempting to require the missing dependency.
Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

cause and package name included for MongoMissingDependencyErrors

MongoMissingDependencyErrors now include a cause and a dependencyName field, which can be used to programmatically determine which package is missing and why the driver failed to load it.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket
@baileympearson baileympearson changed the title add more descriptive error info feat(NODE-5762): include cause and package name for all MongoMissingDependencyErrors Apr 3, 2024
baileympearson
baileympearson commented Apr 3, 2024
View reviewed changes
@nbbeeken nbbeeken self-assigned this Apr 3, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 3, 2024
nbbeeken
nbbeeken suggested changes Apr 3, 2024
View reviewed changes
@baileympearson baileympearson requested a review from addaleax April 4, 2024 14:24
@baileympearson baileympearson marked this pull request as ready for review April 4, 2024 14:24
@baileympearson baileympearson requested a review from nbbeeken April 4, 2024 14:33
nbbeeken
nbbeeken suggested changes Apr 4, 2024
View reviewed changes
@baileympearson baileympearson requested a review from nbbeeken April 4, 2024 15:59
nbbeeken
nbbeeken previously approved these changes Apr 4, 2024
View reviewed changes
addaleax
addaleax previously approved these changes Apr 5, 2024
View reviewed changes
@baileympearson baileympearson dismissed stale reviews from addaleax and nbbeeken via 45cca73 April 5, 2024 16:48
@baileympearson @addaleax
Update src/cmap/connection.ts
45cca73 
Co-authored-by: Anna Henningsen <github@addaleax.net>
@baileympearson baileympearson requested a review from nbbeeken April 5, 2024 16:48
@nbbeeken nbbeeken merged commit 62ea94b into mongodb:main Apr 5, 2024
@github-actions github-actions bot mentioned this pull request Apr 5, 2024
Merged
baileympearson added a commit to baileympearson/node-mongodb-native that referenced this pull request Apr 15, 2024
@baileympearson @addaleax
feat(NODE-5762): include cause and package name for all `MongoMissi…
e328c50 
…ngDependencyError`s (mongodb#4067) Co-authored-by: Anna Henningsen <github@addaleax.net>
@NotZarifGithub NotZarifGithub mentioned this pull request May 24, 2024
Open
@kazimanzurrashid kazimanzurrashid mentioned this pull request May 24, 2024
Merged
@tdbaine tdbaine mentioned this pull request May 24, 2024
Open
@arenault-pass arenault-pass mentioned this pull request May 24, 2024
Closed
@lryanle lryanle mentioned this pull request May 24, 2024
Open
@WesleyR10 WesleyR10 mentioned this pull request Aug 22, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Aug 28, 2024
Closed
@jaspreetd jaspreetd mentioned this pull request Sep 2, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Sep 3, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Sep 3, 2024
Open
@lryanle lryanle mentioned this pull request Sep 3, 2024
Open
@lydmoon lydmoon mentioned this pull request Sep 3, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Sep 4, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 6, 2024
Closed
@zntb zntb mentioned this pull request Sep 6, 2024
Merged
This was referenced Sep 7, 2024
Closed
Closed
@snyk-io snyk-io bot mentioned this pull request Sep 16, 2024
Open
@sunil-lakshman sunil-lakshman mentioned this pull request Sep 18, 2024
Closed
This was referenced Sep 24, 2024
Closed
Closed
Closed
Closed
@akanchhaS akanchhaS mentioned this pull request Sep 27, 2024
Open
@MohammadGhajari MohammadGhajari mentioned this pull request Sep 27, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Sep 28, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Sep 28, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 28, 2024
Closed
@lydmoon lydmoon mentioned this pull request Sep 28, 2024
Open
@lryanle lryanle mentioned this pull request Sep 28, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Sep 28, 2024
Open
@sunil-lakshman sunil-lakshman mentioned this pull request Sep 28, 2024
Closed
This was referenced Oct 1, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

3 participants

@baileympearson @addaleax @nbbeeken