Skip to content

Commit a69012e

Browse files
author
Mike Dirolf
committed
minor: don't inline and only define buffer_write_bytes once
1 parent 1440f42 commit a69012e

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

bson/_cbson.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ typedef int Py_ssize_t;
2626
#define PY_SSIZE_T_MIN INT_MIN
2727
#endif
2828

29+
int buffer_write_bytes(buffer_t buffer, const char* data, int size);
30+
2931
int write_dict(buffer_t buffer, PyObject* dict,
3032
unsigned char check_keys, unsigned char top_level);
3133

bson/_cbsonmodule.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ static long long millis_from_datetime(PyObject* datetime) {
124124
}
125125

126126
/* Just make this compatible w/ the old API. */
127-
static inline int buffer_write_bytes(buffer_t buffer, const char* data, int size) {
127+
int buffer_write_bytes(buffer_t buffer, const char* data, int size) {
128128
if (buffer_write(buffer, data, size)) {
129129
PyErr_NoMemory();
130130
return 0;

pymongo/_cmessagemodule.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,6 @@
2525
#include "_cbson.h"
2626
#include "buffer.h"
2727

28-
/* Just make this compatible w/ the old API. */
29-
static inline int buffer_write_bytes(buffer_t buffer, const char* data, int size) {
30-
if (buffer_write(buffer, data, size)) {
31-
PyErr_NoMemory();
32-
return 0;
33-
}
34-
return 1;
35-
}
36-
3728
/* Get an error class from the pymongo.errors module.
3829
*
3930
* Returns a new ref */

0 commit comments

Comments
 (0)