Fix indentation level of CHANGELOG entries #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kevinAlbs approved these changes Nov 20, 2024
Collaborator
kevinAlbs left a comment
kevinAlbs left a comment There was a problem hiding this comment.
LGTM with a suggested step removed.
etc/releasing.md Outdated
| distribution tarball. | ||
| - If the script succeeded at creating the distribution tarball, pass it directly | ||
| with `--dist-file ./build/mongo-cxx-driver-rX.Y.Z.tar.gz`. | ||
| - If the only open JIRA ticket is the ticket tracking the release itself, pass `--allow-open-issues`. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - If the only open JIRA ticket is the ticket tracking the release itself, pass `--allow-open-issues`. |
I expect this is not needed. An automation creates the "Release x.y.z" ticket when a fixVersion is added. The created ticket gets a release label (example CXX-3104). Tickets with the release label are filtered out.
I expect the "Release 4.0.0" ticket was created manually and did not get the label.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Unintentionally(?) detected by the
etc/make_release.pyscript: