Merged implementation of CSHARP-471 with some changes.

Author: rstam

Driver/Linq/Expressions/ExpressionVisitorGeneric.cs

@@ -40,7 +40,7 @@ protected ExpressionVisitor()
  /// Visits an Expression.
  /// </summary>
  /// <param name="node">The Expression.</param>
- /// <returns>The Expression (posibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T Visit(Expression node)
  {
  if (node == null)
@@ -116,7 +116,7 @@ protected virtual T Visit(Expression node)
  /// Visits an Expression list.
  /// </summary>
  /// <param name="nodes">The Expression list.</param>
- /// <returns>The Expression list (possibly modified).</returns>
+ /// <returns>The result of visiting the Expressions.</returns>
  protected T Visit(ReadOnlyCollection<Expression> nodes)
  {
  for (int i = 0, n = nodes.Count; i < n; i++)
@@ -130,7 +130,7 @@ protected T Visit(ReadOnlyCollection<Expression> nodes)
  /// Visits a BinaryExpression.
  /// </summary>
  /// <param name="node">The BinaryExpression.</param>
- /// <returns>The BinaryExpression (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitBinary(BinaryExpression node)
  {
  this.Visit(node.Left);
@@ -143,7 +143,7 @@ protected virtual T VisitBinary(BinaryExpression node)
  /// Visits a ConditionalExpression.
  /// </summary>
  /// <param name="node">The ConditionalExpression.</param>
- /// <returns>The ConditionalExpression (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitConditional(ConditionalExpression node)
  {
  this.Visit(node.Test);
@@ -156,7 +156,7 @@ protected virtual T VisitConditional(ConditionalExpression node)
  /// Visits a ConstantExpression.
  /// </summary>
  /// <param name="node">The ConstantExpression.</param>
- /// <returns>The ConstantExpression (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitConstant(ConstantExpression node)
  {
  return default(T);
@@ -166,7 +166,7 @@ protected virtual T VisitConstant(ConstantExpression node)
  /// Visits an ElementInit.
  /// </summary>
  /// <param name="node">The ElementInit.</param>
- /// <returns>The ElementInit (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitElementInit(ElementInit node)
  {
  this.Visit(node.Arguments);
@@ -180,7 +180,7 @@ protected virtual T VisitElementInit(ElementInit node)
  /// Visits an ElementInit list.
  /// </summary>
  /// <param name="nodes">The ElementInit list.</param>
- /// <returns>The ElementInit list (possibly modified).</returns>
+ /// <returns>The result of visiting the Expressions.</returns>
  protected T VisitElementInitList(
  ReadOnlyCollection<ElementInit> nodes)
  {
@@ -195,7 +195,7 @@ protected T VisitElementInitList(
  /// Visits an InvocationExpression.
  /// </summary>
  /// <param name="node">The InvocationExpression.</param>
- /// <returns>The InvocationExpression (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitInvocation(InvocationExpression node)
  {
  this.Visit(node.Arguments);
@@ -210,7 +210,7 @@ protected virtual T VisitInvocation(InvocationExpression node)
  /// Visits a LambdaExpression.
  /// </summary>
  /// <param name="node">The LambdaExpression.</param>
- /// <returns>The LambdaExpression (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitLambda(LambdaExpression node)
  {
  this.Visit(node.Body);
@@ -221,7 +221,7 @@ protected virtual T VisitLambda(LambdaExpression node)
  /// Visits a ListInitExpression.
  /// </summary>
  /// <param name="node">The ListInitExpression.</param>
- /// <returns>The ListInitExpression (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitListInit(ListInitExpression node)
  {
  this.VisitNew(node.NewExpression);
@@ -233,7 +233,7 @@ protected virtual T VisitListInit(ListInitExpression node)
  /// Visits a MemberExpression.
  /// </summary>
  /// <param name="node">The MemberExpression.</param>
- /// <returns>The MemberExpression (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitMember(MemberExpression node)
  {
  this.Visit(node.Expression);
@@ -244,7 +244,7 @@ protected virtual T VisitMember(MemberExpression node)
  /// Visits a MemberAssignment.
  /// </summary>
  /// <param name="node">The MemberAssignment.</param>
- /// <returns>The MemberAssignment (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitMemberAssignment(MemberAssignment node)
  {
  this.Visit(node.Expression);
@@ -255,7 +255,7 @@ protected virtual T VisitMemberAssignment(MemberAssignment node)
  /// Visits a MemberBinding.
  /// </summary>
  /// <param name="node">The MemberBinding.</param>
- /// <returns>The MemberBinding (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitMemberBinding(MemberBinding node)
  {
  switch (node.BindingType)
@@ -278,7 +278,7 @@ protected virtual T VisitMemberBinding(MemberBinding node)
  /// Visits a MemberBinding list.
  /// </summary>
  /// <param name="nodes">The MemberBinding list.</param>
- /// <returns>The MemberBinding list (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitMemberBindingList(ReadOnlyCollection<MemberBinding> nodes)
  {
  for (int i = 0, n = nodes.Count; i < n; i++)
@@ -292,7 +292,7 @@ protected virtual T VisitMemberBindingList(ReadOnlyCollection<MemberBinding> nod
  /// Visits a MemberInitExpression.
  /// </summary>
  /// <param name="node">The MemberInitExpression.</param>
- /// <returns>The MemberInitExpression (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitMemberInit(MemberInitExpression node)
  {
  this.VisitNew(node.NewExpression);
@@ -304,7 +304,7 @@ protected virtual T VisitMemberInit(MemberInitExpression node)
  /// Visits a MemberListBinding.
  /// </summary>
  /// <param name="node">The MemberListBinding.</param>
- /// <returns>The MemberListBinding (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitMemberListBinding(MemberListBinding node)
  {
  this.VisitElementInitList(node.Initializers);
@@ -315,7 +315,7 @@ protected virtual T VisitMemberListBinding(MemberListBinding node)
  /// Visits a MemberMemberBinding.
  /// </summary>
  /// <param name="node">The MemberMemberBinding.</param>
- /// <returns>The MemberMemberBinding (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitMemberMemberBinding(MemberMemberBinding node)
  {
  this.VisitMemberBindingList(node.Bindings);
@@ -326,7 +326,7 @@ protected virtual T VisitMemberMemberBinding(MemberMemberBinding node)
  /// Visits a MethodCallExpression.
  /// </summary>
  /// <param name="node">The MethodCallExpression.</param>
- /// <returns>The MethodCallExpression (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitMethodCall(MethodCallExpression node)
  {
  this.Visit(node.Object);
@@ -338,7 +338,7 @@ protected virtual T VisitMethodCall(MethodCallExpression node)
  /// Visits a NewExpression.
  /// </summary>
  /// <param name="node">The NewExpression.</param>
- /// <returns>The NewExpression (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitNew(NewExpression node)
  {
  this.Visit(node.Arguments);
@@ -349,7 +349,7 @@ protected virtual T VisitNew(NewExpression node)
  /// Visits a NewArrayExpression.
  /// </summary>
  /// <param name="node">The NewArrayExpression.</param>
- /// <returns>The NewArrayExpression (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitNewArray(NewArrayExpression node)
  {
  this.Visit(node.Expressions);
@@ -360,7 +360,7 @@ protected virtual T VisitNewArray(NewArrayExpression node)
  /// Visits a ParameterExpression.
  /// </summary>
  /// <param name="node">The ParameterExpression.</param>
- /// <returns>The ParameterExpression (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitParameter(ParameterExpression node)
  {
  return default(T);
@@ -370,7 +370,7 @@ protected virtual T VisitParameter(ParameterExpression node)
  /// Visits a TypeBinaryExpression.
  /// </summary>
  /// <param name="node">The TypeBinaryExpression.</param>
- /// <returns>The TypeBinaryExpression (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitTypeBinary(TypeBinaryExpression node)
  {
  this.Visit(node.Expression);
@@ -381,7 +381,7 @@ protected virtual T VisitTypeBinary(TypeBinaryExpression node)
  /// Visits a UnaryExpression.
  /// </summary>
  /// <param name="node">The UnaryExpression.</param>
- /// <returns>The UnaryExpression (possibly modified).</returns>
+ /// <returns>The result of visiting the Expression.</returns>
  protected virtual T VisitUnary(UnaryExpression node)
  {
  this.Visit(node.Operand);