CDRIVER-4225 Explicitly set CA and cert file for use by KMS TLS connections #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Thanks to CDRIVER-4206, the KMS TLS connections can now use user-provided CA and certificate files rather than depending on system certificate registration. This PR removes system cert registration and associated test skip condition checks, replacing them with use of the new
tls_optsfields whose values are set by theMONGOC_TEST_CSFLE_TLS_CA_FILEandMONGOC_TEST_CSFLE_TLS_CERTIFICATE_KEY_FILEenvironment variables.