CDRIVER-3320 Add BSON_GNUC_WARN_UNUSED_RESULT to exported functions #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jmikola approved these changes Aug 27, 2021
kevinAlbs reviewed Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
All functions declared with
MONGOC_EXPORTwere examined in this pass.Any exported functions whose return value which the C driver documentation described as "newly allocated" or "should be freed" were given the
BSON_GNUC_WARN_UNUSED_RESULTattribute. If there was not a documentation page corresponding to the function, or if the documentation did not describe how the result should be handled, the definition was examined for the presence of any calls to a*_new()-like,*_malloc()-like,*_copy(), or*_clone()-like functions as an indicator instead.No additional warnings appear to have been generated relative to base commit (583213d) as a result of these changes when building the C driver. Yay for no (obvious) leaks!🎉
Code formatting was also applied to all modified files. These formatting changes can be reverted if deemed unnecessary.