CDRIVER-4106 Update numbers for existing SRV polling prose tests. #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
chardan reviewed Aug 10, 2021
Contributor
chardan left a comment
chardan left a comment There was a problem hiding this comment.
I think this looks ok (I did have a question about naming), but I'm not yet very familiar with these tests, so it's tough for me to give solid direction beyond my impressions. But, you've got a few other reviewers who may have more concrete ideas. :-)
Only prose test 9 is currently implemented according to spec. Behavior of test_srv_polling_mocked does not conform to prose tests described by spec. Therefore, only names related to prose test 9 are updated with numbering. Prose tests 1 through 8 are to be implemented separately; see CDRIVER-4125.
eramongodb force-pushed the cdriver-4106 branch from a2040f9 to 11dcdd4 Compare 
eramongodb commented Aug 10, 2021
kevinAlbs approved these changes Aug 11, 2021
Collaborator
kevinAlbs left a comment
kevinAlbs left a comment There was a problem hiding this comment.
LGTM! Thank you for including a detailed description.
vector-of-bool approved these changes Aug 12, 2021
Contributor
vector-of-bool left a comment
vector-of-bool left a comment There was a problem hiding this comment.
LGTM. My only questions/nits were already asked an answered in the associated conversations.
chardan approved these changes Aug 12, 2021
Contributor
chardan left a comment
chardan left a comment There was a problem hiding this comment.
+1, great work getting this through! :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Only prose test 9 is currently implemented according to spec. Behavior of
test_srv_polling_mockeddoes not conform to prose tests described by spec. Therefore, only names related to prose test 9 are updated with numbering.Prose tests 1 through 8 are to be implemented separately; see CDRIVER-4125.
This resolves CDRIVER-4106.
Names of tests and test functions are modelled after existing numbered prose tests such as those in test-mongoc-crud.c.