fix(NODE-4464):stringify and parse negative zero to and from $numberDouble: -0.0 #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nbbeeken force-pushed the NODE-4464-neg-zero-ejson branch from de2f9c3 to 7b1d892 Compare 
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
nbbeeken force-pushed the NODE-4464-neg-zero-ejson branch from 7b1d892 to fcb377b Compare 
baileympearson requested changes Dec 1, 2022
| Can we change the title of the PR to accurately reflect the contents? The PR now handles parsing ejson with negative zeroes as well. |
baileympearson approved these changes Dec 1, 2022
nbbeeken changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
EJSON when in
relaxed: falsemode (cannonical) is supposed to serialize negative zero to a double.What is the motivation for this change?
EJSON implementation correctness
Double check the following
npm run lintscript<type>(NODE-xxxx)<!>: <description>