Skip to content

Commit 335e91d

Browse files
miorelzpao
authored andcommitted
Fix console warning in LegacyImmutableObject
It does check `hasOwnProperty`, but *after* accessing the field and therefore triggering enumerable getters in modified prototypes.
1 parent 944f49c commit 335e91d

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/utils/LegacyImmutableObject.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,11 @@ if (__DEV__) {
8181
}
8282
Object.freeze(object); // First freeze the object.
8383
for (var prop in object) {
84-
var field = object[prop];
85-
if (object.hasOwnProperty(prop) && shouldRecurseFreeze(field)) {
86-
deepFreeze(field);
84+
if (object.hasOwnProperty(prop)) {
85+
var field = object[prop];
86+
if (shouldRecurseFreeze(field)) {
87+
deepFreeze(field);
88+
}
8789
}
8890
}
8991
};

0 commit comments

Comments
 (0)