Skip to content

Commit a22da49

Browse files
committed
fix(building-rollup): apply user provided developmentMode
1 parent 7a8f165 commit a22da49

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

.changeset/tall-onions-sort.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@rocket/building-rollup': patch
3+
---
4+
5+
Make sure user provided `developmentMode` actually gets applied.

packages/building-rollup/src/createBasicConfig.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export function createBasicConfig(userConfig) {
1313

1414
export function createBasicMetaConfig(userConfig = { output: {} }) {
1515
const developmentMode =
16-
typeof userConfig.developmentMode !== undefined
16+
typeof userConfig.developmentMode !== 'undefined'
1717
? userConfig.developmentMode
1818
: !!process.env.ROLLUP_WATCH;
1919
delete userConfig.developmentMode;

packages/building-rollup/src/createServiceWorkerConfig.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export function createServiceWorkerConfig(userConfig) {
1414

1515
export function createServiceWorkerMetaConfig(userConfig = { output: {} }) {
1616
const developmentMode =
17-
typeof userConfig.developmentMode !== undefined
17+
typeof userConfig.developmentMode !== 'undefined'
1818
? userConfig.developmentMode
1919
: !!process.env.ROLLUP_WATCH;
2020
delete userConfig.developmentMode;

0 commit comments

Comments
 (0)