Skip to content

Commit 36e053a

Browse files
Adjust e2e test configuration
- Playwright installation can take more than 5m, increase to 15m - Only attempt to upload the report if Playwright executed, otherwise there are no report files, and the upload step will error
1 parent 73bb000 commit 36e053a

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.github/workflows/e2e_tests.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ on:
88

99
jobs:
1010
test:
11-
timeout-minutes: 5
11+
# Installing Playright dependencies can take quite awhile, and also depends on GitHub CI load.
12+
timeout-minutes: 15
1213
runs-on: ubuntu-latest
1314

1415
steps:
@@ -44,11 +45,12 @@ jobs:
4445
if: steps.cache-playwright.outputs.cache-hit != 'true'
4546

4647
- name: Run Playwright tests
48+
id: playwright-tests
4749
run: npm run test:e2e
4850

4951
- name: Upload Playwright Report and Screenshots
5052
uses: actions/upload-artifact@v4
51-
if: always()
53+
if: steps.playwright-tests.conclusion != 'skipped'
5254
with:
5355
name: playwright-report
5456
path: |
@@ -59,7 +61,7 @@ jobs:
5961

6062
- name: Publish Playwright Test Summary
6163
uses: daun/playwright-report-summary@v3
62-
if: always()
64+
if: steps.playwright-tests.conclusion != 'skipped'
6365
with:
6466
create-comment: ${{ github.event.pull_request.head.repo.full_name == github.repository }}
6567
report-file: client/results.json

0 commit comments

Comments
 (0)