[flang][Semantics] set scope even for module subroutines outside modules (llvm#109009)

The missing scope information led to a crash in OpenMP semantic checks run before printing the error that was already discovered in the code. The following block has to be skipped for this invalid code so that we don't emit a second spurious error. Fixes llvm#82913

Author: tblah

flang/lib/Semantics/resolve-names.cpp

@@ -4351,15 +4351,18 @@ bool SubprogramVisitor::BeginSubprogram(const parser::Name &name,
  Symbol::Flag subpFlag, bool hasModulePrefix,
  const parser::LanguageBindingSpec *bindingSpec,
  const ProgramTree::EntryStmtList *entryStmts) {
+ bool isValid{true};
  if (hasModulePrefix && !currScope().IsModule() &&
  !currScope().IsSubmodule()) { // C1547
  Say(name,
  "'%s' is a MODULE procedure which must be declared within a "
  "MODULE or SUBMODULE"_err_en_US);
- return false;
+ // Don't return here because it can be useful to have the scope set for
+ // other semantic checks run before we print the errors
+ isValid = false;
  }
  Symbol *moduleInterface{nullptr};
- if (hasModulePrefix && !inInterfaceBlock()) {
+ if (isValid && hasModulePrefix && !inInterfaceBlock()) {
  moduleInterface = FindSeparateModuleProcedureInterface(name);
  if (moduleInterface && &moduleInterface->owner() == &currScope()) {
  // Subprogram is MODULE FUNCTION or MODULE SUBROUTINE with an interface

flang/test/Semantics/OpenMP/bad_module_subroutine.f90

@@ -0,0 +1,6 @@
+! RUN: %python %S/../test_errors.py %s %flang_fc1 -fopenmp
+! Test that we don't crash on this code inside of openmp semantics checks
+
+!ERROR: 'e' is a MODULE procedure which must be declared within a MODULE or SUBMODULE
+impure elemental module subroutine e()
+end subroutine