[Java] Consistent use of System properties.

Author: mjpt777

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/TargetCodeGeneratorLoader.java

@@ -47,9 +47,9 @@ public CodeGenerator newInstance(final Ir ir, final String outputDir)
  ir,
  System.getProperty(JAVA_ENCODING_BUFFER_TYPE, JAVA_DEFAULT_ENCODING_BUFFER_TYPE),
  System.getProperty(JAVA_DECODING_BUFFER_TYPE, JAVA_DEFAULT_DECODING_BUFFER_TYPE),
- Boolean.getBoolean(JAVA_GROUP_ORDER_ANNOTATION),
- Boolean.getBoolean(JAVA_GENERATE_INTERFACES),
- Boolean.getBoolean(DECODE_UNKNOWN_ENUM_VALUES),
+ "true".equals(System.getProperty(JAVA_GROUP_ORDER_ANNOTATION)),
+ "true".equals(System.getProperty(JAVA_GENERATE_INTERFACES)),
+ "true".equals(System.getProperty(DECODE_UNKNOWN_ENUM_VALUES)),
  new PackageOutputManager(outputDir, ir.applicableNamespace()));
  }
  },
@@ -80,7 +80,7 @@ public CodeGenerator newInstance(final Ir ir, final String outputDir)
  {
  return new CppGenerator(
  ir,
- Boolean.getBoolean(DECODE_UNKNOWN_ENUM_VALUES),
+ "true".equals(System.getProperty(DECODE_UNKNOWN_ENUM_VALUES)),
  new NamespaceOutputManager(outputDir, ir.applicableNamespace()));
  }
  },

sbe-tool/src/main/java/uk/co/real_logic/sbe/ir/Ir.java

@@ -79,7 +79,7 @@ public Ir(
 
  captureTypes(headerTokens, 0, headerTokens.size() - 1);
 
- if (Boolean.getBoolean(SbeTool.CPP_NAMESPACES_COLLAPSE))
+ if ("true".equals(System.getProperty(SbeTool.CPP_NAMESPACES_COLLAPSE)))
  {
  this.namespaces = new String[]{ (namespaceName == null ? packageName : namespaceName).replace(".", "_") };
  }

sbe-tool/src/main/java/uk/co/real_logic/sbe/xml/CompositeType.java

@@ -302,7 +302,7 @@ else if (primitiveType == UINT32)
  */
  public void checkForWellFormedMessageHeader(final Node node)
  {
- final boolean shouldGenerateInterfaces = Boolean.getBoolean(JAVA_GENERATE_INTERFACES);
+ final boolean shouldGenerateInterfaces = "true".equals(System.getProperty(JAVA_GENERATE_INTERFACES));
 
  final EncodedDataType blockLengthType = (EncodedDataType)containedTypeByNameMap.get("blockLength");
  final EncodedDataType templateIdType = (EncodedDataType)containedTypeByNameMap.get("templateId");