Do not fail interpreter discovery if accessing Windows registry fails. (#13369)

* Do not fail discovery if accessing Windows registry fails * News entry

Author: Kartik Raj

news/2 Fixes/12962.md

@@ -0,0 +1 @@
+Do not fail interpreter discovery if accessing Windows registry fails.

src/client/common/platform/registry.ts

@@ -1,5 +1,6 @@
 import { injectable } from 'inversify';
 import { Options } from 'winreg';
+import { traceError } from '../logger';
 import { Architecture } from '../utils/platform';
 import { IRegistry, RegistryHive } from './types';
 
@@ -11,10 +12,18 @@ enum RegistryArchitectures {
 @injectable()
 export class RegistryImplementation implements IRegistry {
  public async getKeys(key: string, hive: RegistryHive, arch?: Architecture) {
- return getRegistryKeys({ hive: translateHive(hive)!, arch: translateArchitecture(arch), key });
+ return getRegistryKeys({ hive: translateHive(hive)!, arch: translateArchitecture(arch), key }).catch((ex) => {
+ traceError('Fetching keys from windows registry resulted in an error', ex);
+ return [];
+ });
  }
  public async getValue(key: string, hive: RegistryHive, arch?: Architecture, name: string = '') {
- return getRegistryValue({ hive: translateHive(hive)!, arch: translateArchitecture(arch), key }, name);
+ return getRegistryValue({ hive: translateHive(hive)!, arch: translateArchitecture(arch), key }, name).catch(
+ (ex) => {
+ traceError('Fetching key value from windows registry resulted in an error', ex);
+ return undefined;
+ }
+ );
  }
 }
 

src/client/pythonEnvironments/discovery/locators/services/windowsRegistryService.ts

@@ -47,7 +47,12 @@ export class WindowsRegistryService extends CacheableLocatorService {
  // tslint:disable-next-line:no-empty
  public dispose() {}
  protected async getInterpretersImplementation(_resource?: Uri): Promise<PythonInterpreter[]> {
- return this.platform.isWindows ? this.getInterpretersFromRegistry() : [];
+ return this.platform.isWindows
+ ? this.getInterpretersFromRegistry().catch((ex) => {
+ traceError('Fetching interpreters from registry failed with error', ex);
+ return [];
+ })
+ : [];
  }
  private async getInterpretersFromRegistry() {
  // https://github.com/python/peps/blob/master/pep-0514.txt#L357