Add trust feature for VS Code Notebooks (#12818)

Author: DonJayamanne

build/ci/vscode-python-pr-validation.yaml

@@ -56,6 +56,7 @@ stages:
  'DataScience':
  TestsToRun: 'testDataScience'
  NeedsPythonTestReqs: true
+ NeedsPythonFunctionalReqs: true
  'Smoke':
  TestsToRun: 'testSmoke'
  NeedsPythonTestReqs: true

package.json

@@ -694,6 +694,25 @@
  },
  "enablement": "python.datascience.notebookeditor.canrestartNotebookkernel"
  },
+ {
+ "command": "python.datascience.notebookeditor.trust",
+ "title": "%DataScience.trustNotebookCommandTitle%",
+ "category": "Python",
+ "icon": {
+ "light": "resources/light/un-trusted.svg",
+ "dark": "resources/dark/un-trusted.svg"
+ },
+ "enablement": "notebookEditorFocused && !python.datascience.isnotebooktrusted && python.datascience.trustfeatureenabled"
+ },
+ {
+ "command": "python.datascience.notebookeditor.trusted",
+ "title": "%DataScience.notebookIsTrusted%",
+ "category": "Python",
+ "icon": {
+ "light": "resources/light/trusted.svg",
+ "dark": "resources/dark/trusted.svg"
+ }
+ },
  {
  "command": "python.datascience.notebookeditor.runallcells",
  "title": "%python.command.python.datascience.notebookeditor.runallcells.title%",
@@ -860,6 +879,18 @@
  "group": "navigation",
  "when": "notebookEditorFocused"
  },
+ {
+ "command": "python.datascience.notebookeditor.trust",
+ "title": "%DataScience.trustNotebookCommandTitle%",
+ "group": "navigation@1",
+ "when": "notebookEditorFocused && !python.datascience.isnotebooktrusted && python.datascience.trustfeatureenabled"
+ },
+ {
+ "command": "python.datascience.notebookeditor.trusted",
+ "title": "%DataScience.notebookIsTrusted%",
+ "group": "navigation@1",
+ "when": "notebookEditorFocused && python.datascience.isnotebooktrusted && python.datascience.trustfeatureenabled"
+ },
  {
  "command": "python.datascience.export",
  "title": "%DataScience.notebookExportAs%",
@@ -1138,6 +1169,18 @@
  "category": "Python",
  "when": "python.datascience.isnativeactive && python.datascience.featureenabled && python.datascience.isnotebooktrusted"
  },
+ {
+ "command": "python.datascience.notebookeditor.trust",
+ "title": "%DataScience.trustNotebookCommandTitle%",
+ "category": "Python",
+ "when": "python.datascience.featureenabled && notebookEditorFocused && !python.datascience.isnotebooktrusted && python.datascience.trustfeatureenabled"
+ },
+ {
+ "command": "python.datascience.notebookeditor.trusted",
+ "title": "%DataScience.notebookIsTrusted%",
+ "category": "Python",
+ "when": "config.noExists"
+ },
  {
  "command": "python.datascience.notebookeditor.runallcells",
  "title": "%python.command.python.datascience.notebookeditor.runallcells.title%",

package.nls.json

@@ -370,6 +370,7 @@
  "DataScience.fetchingDataViewer": "Fetching data ...",
  "DataScience.noRowsInDataViewer": "No rows match current filter",
  "DataScience.jupyterServer": "Jupyter Server",
+ "DataScience.trustNotebookCommandTitle": "Trust notebook",
  "DataScience.notebookIsTrusted": "Trusted",
  "DataScience.notebookIsNotTrusted": "Not Trusted",
  "DataScience.noKernel": "No Kernel",

resources/dark/trusted.svg

@@ -183,4 +183,6 @@ export interface ICommandNameArgumentTypeMapping extends ICommandNameWithoutArgu
  [DSCommands.OpenNotebookNonCustomEditor]: [Uri];
  [DSCommands.GatherQuality]: [string];
  [DSCommands.EnableLoadingWidgetsFrom3rdPartySource]: [undefined | never];
+ [DSCommands.TrustNotebook]: [undefined | never | Uri];
+ [DSCommands.TrustedNotebook]: [undefined | never];
 }

resources/dark/un-trusted.svg

@@ -90,6 +90,8 @@ export namespace Commands {
  export const SaveAsNotebookNonCustomEditor = 'python.datascience.notebookeditor.saveAs';
  export const OpenNotebookNonCustomEditor = 'python.datascience.notebookeditor.open';
  export const GatherQuality = 'python.datascience.gatherquality';
+ export const TrustNotebook = 'python.datascience.notebookeditor.trust';
+ export const TrustedNotebook = 'python.datascience.notebookeditor.trusted';
  export const EnableLoadingWidgetsFrom3rdPartySource =
  'python.datascience.enableLoadingWidgetScriptsFromThirdPartySource';
 }