Do not crash if hitting a unsupported intrinsic type #3077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
timotheeguerin requested review from allenjzhang, bterlson and markcowl as code owners 
Collaborator
| All changed packages have been documented. |
Collaborator
| You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3077/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3077/ |
bterlson approved these changes Mar 28, 2024
Member
bterlson left a comment
bterlson left a comment There was a problem hiding this comment.
Yeah, not crashing is better than crashing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix #3073
This still doesn't provide an optimal experience as the error shows up on the void type instead of where it is referenced but solving that is that long standing issue about tracing back where an error should be