Skip to content

Commit 4ae4c3c

Browse files
authored
browser(webkit): fix response.requestHeaders instrumentation in libsoup after latest roll (#5549)
1 parent 8316f41 commit 4ae4c3c

File tree

2 files changed

+36
-12
lines changed

2 files changed

+36
-12
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
1439
2-
Changed: yurys@chromium.org Mon 22 Feb 2021 12:39:50 PM PST
1+
1440
2+
Changed: yurys@chromium.org Mon 22 Feb 2021 02:23:33 PM PST

browser_patches/webkit/patches/bootstrap.diff

Lines changed: 34 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8384,10 +8384,18 @@ index 4c120d6830582861432e5e58fba5707206350cd0..3509c62ac2c970fdcf78db2503c0cc42
83848384
bool isThirdPartyRequest(const WebCore::ResourceRequest&);
83858385
bool shouldBlockCookies(const WebCore::ResourceRequest&);
83868386
diff --git a/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp b/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
8387-
index 435980eb8eff1749afd65ea09941d257a0a9cfc1..f8ff58861d367bfcf5104d5b3d9de7f3e6e7864d 100644
8387+
index 435980eb8eff1749afd65ea09941d257a0a9cfc1..69a63ca6d28ed9c569176c2058d7a0e86ae1b3e8 100644
83888388
--- a/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
83898389
+++ b/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
8390-
@@ -490,6 +490,8 @@ bool NetworkDataTaskSoup::acceptCertificate(GTlsCertificate* certificate, GTlsCe
8390+
@@ -404,6 +404,7 @@ void NetworkDataTaskSoup::didSendRequest(GRefPtr<GInputStream>&& inputStream)
8391+
m_inputStream = WTFMove(inputStream);
8392+
8393+
m_networkLoadMetrics.responseStart = MonotonicTime::now() - m_startTime;
8394+
+ m_response.m_httpRequestHeaderFields = m_networkLoadMetrics.requestHeaders;
8395+
dispatchDidReceiveResponse();
8396+
}
8397+
8398+
@@ -490,6 +491,8 @@ bool NetworkDataTaskSoup::acceptCertificate(GTlsCertificate* certificate, GTlsCe
83918399
{
83928400
ASSERT(m_soupMessage);
83938401
URL url = soupURIToURL(soup_message_get_uri(m_soupMessage.get()));
@@ -8396,14 +8404,6 @@ index 435980eb8eff1749afd65ea09941d257a0a9cfc1..f8ff58861d367bfcf5104d5b3d9de7f3
83968404
auto error = static_cast<NetworkSessionSoup&>(*m_session).soupNetworkSession().checkTLSErrors(url, certificate, tlsErrors);
83978405
if (!error)
83988406
return true;
8399-
@@ -1001,6 +1003,7 @@ void NetworkDataTaskSoup::didGetHeaders()
8400-
const char* headerValue;
8401-
while (soup_message_headers_iter_next(&headersIter, &headerName, &headerValue))
8402-
requestHeaders.set(String(headerName), String(headerValue));
8403-
+ m_response.m_httpRequestHeaderFields = requestHeaders;
8404-
m_networkLoadMetrics.requestHeaders = WTFMove(requestHeaders);
8405-
}
8406-
}
84078407
diff --git a/Source/WebKit/NetworkProcess/soup/NetworkSessionSoup.cpp b/Source/WebKit/NetworkProcess/soup/NetworkSessionSoup.cpp
84088408
index 6e973f518c176c589e426bd6f466b1a7552828d4..8df1134613da2d817147bc5db3d30f5d29d994fb 100644
84098409
--- a/Source/WebKit/NetworkProcess/soup/NetworkSessionSoup.cpp
@@ -9762,6 +9762,30 @@ index 0000000000000000000000000000000000000000..e7143513ea2be8e1cdab5c86a28643ff
97629762
+ [super dealloc];
97639763
+}
97649764
+@end
9765+
diff --git a/Source/WebKit/UIProcess/API/Cocoa/_WKDownload.mm b/Source/WebKit/UIProcess/API/Cocoa/_WKDownload.mm
9766+
index 913f53a5411894c29ebfe0d7f07fb7b60207af08..f198b4f05a5bcfe3455af157628791d549f181b0 100644
9767+
--- a/Source/WebKit/UIProcess/API/Cocoa/_WKDownload.mm
9768+
+++ b/Source/WebKit/UIProcess/API/Cocoa/_WKDownload.mm
9769+
@@ -32,6 +32,7 @@
9770+
#import "WKFrameInfoInternal.h"
9771+
#import "WKNSData.h"
9772+
#import "WKWebViewInternal.h"
9773+
+#import <wtf/cocoa/VectorCocoa.h>
9774+
#import <wtf/WeakObjCPtr.h>
9775+
9776+
ALLOW_DEPRECATED_DECLARATIONS_BEGIN
9777+
diff --git a/Source/WebKit/UIProcess/API/Cocoa/_WKDownloadInternal.h b/Source/WebKit/UIProcess/API/Cocoa/_WKDownloadInternal.h
9778+
index ca94c2173757a54a0c755cbf30f8e05a0b75c9cb..422c1379da9b091ae5903a42bc7625be78030016 100644
9779+
--- a/Source/WebKit/UIProcess/API/Cocoa/_WKDownloadInternal.h
9780+
+++ b/Source/WebKit/UIProcess/API/Cocoa/_WKDownloadInternal.h
9781+
@@ -24,6 +24,7 @@
9782+
*/
9783+
9784+
#import "_WKDownload.h"
9785+
+#import "WKObject.h"
9786+
9787+
#import <wtf/RetainPtr.h>
9788+
97659789
diff --git a/Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.mm b/Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.mm
97669790
index 267f0ef93383958437840f00c2baa76bfd79cf5e..aa26067356677749c4f0e3b2f0a851b13707db66 100644
97679791
--- a/Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.mm

0 commit comments

Comments
 (0)