Cherry-pick PR #50279 into release-4.8 (#50280)

Component commits: eff4406 Revert "Fixed an issue with contextual type for intersection properties (#48668)" This reverts commit 9236e39. Co-authored-by: Ryan Cavanaugh <RyanCavanaugh@users.noreply.github.com>

Author: TypeScript Bot

src/compiler/checker.ts

@@ -27124,37 +27124,16 @@ namespace ts {
  }
 
  function getTypeOfPropertyOfContextualType(type: Type, name: __String, nameType?: Type) {
- return mapType(type, (t): Type | undefined => {
- if (t.flags & TypeFlags.Intersection) {
- const intersection = t as IntersectionType;
- let newTypes = mapDefined(intersection.types, getTypeOfConcretePropertyOfContextualType);
- if (newTypes.length > 0) {
- return getIntersectionType(newTypes);
- }
- newTypes = mapDefined(intersection.types, getTypeOfApplicableIndexInfoOfContextualType);
- if (newTypes.length > 0) {
- return getIntersectionType(newTypes);
- }
- return undefined;
- }
- const concretePropertyType = getTypeOfConcretePropertyOfContextualType(t);
- if (concretePropertyType) {
- return concretePropertyType;
- }
- return getTypeOfApplicableIndexInfoOfContextualType(t);
- }, /*noReductions*/ true);
-
- function getTypeOfConcretePropertyOfContextualType(t: Type) {
+ return mapType(type, t => {
  if (isGenericMappedType(t) && !t.declaration.nameType) {
  const constraint = getConstraintTypeFromMappedType(t);
  const constraintOfConstraint = getBaseConstraintOfType(constraint) || constraint;
  const propertyNameType = nameType || getStringLiteralType(unescapeLeadingUnderscores(name));
  if (isTypeAssignableTo(propertyNameType, constraintOfConstraint)) {
  return substituteIndexedMappedType(t, propertyNameType);
  }
- return undefined;
  }
- if (t.flags & TypeFlags.StructuredType) {
+ else if (t.flags & TypeFlags.StructuredType) {
  const prop = getPropertyOfType(t, name);
  if (prop) {
  return isCircularMappedProperty(prop) ? undefined : getTypeOfSymbol(prop);
@@ -27165,15 +27144,10 @@ namespace ts {
  return restType;
  }
  }
+ return findApplicableIndexInfo(getIndexInfosOfStructuredType(t), nameType || getStringLiteralType(unescapeLeadingUnderscores(name)))?.type;
  }
  return undefined;
- }
- function getTypeOfApplicableIndexInfoOfContextualType(t: Type) {
- if (!(t.flags & TypeFlags.StructuredType)) {
- return undefined;
- }
- return findApplicableIndexInfo(getIndexInfosOfStructuredType(t), nameType || getStringLiteralType(unescapeLeadingUnderscores(name)))?.type;
- }
+ }, /*noReductions*/ true);
  }
 
  // In an object literal contextually typed by a type T, the contextual type of a property assignment is the type of