Quick fix for no-implicit-any errors to add explicit type annotation (#14786)

* Infer from usage quick fix * Change full function singature * Add property/element access support * Fix a few issues * Some cleanup * Expose getArrayType and getPromiseType * Switch to collecting all usage before infering * Infer array and promise type arguments * Handel enums in binary operators * consolidate usage of addCandidateTypes * Handel rest paramters * Properly handel `+=` and `+` inference for numbers and strings * Add print quickfixes debug helper * Add rest param tests * Add optional paramter tests * Handel set accessors * Support getters * Support no implicit any error for variable at use site * Support properties * Only offer quick fix if an infered type other than any is available * Rename functions * Move to a separate namespace * Check cancellation token * Cleanup * Check for accesibile symbols where serializing types * Remove JS support * Reorganize functions * Mark APIs as internal * Fix lint errors * Removed conflict markers. * Update 'createSymbol' to use '__String'. * Fixed most problems relating to '__String' and 'includeJsDocComments' in the fix itself. * Addressed most API changes. * Make all helpers internal * Use a diffrent writer and not the built-in single line write * Infer types for all parameters in a parameter list instead of one at a time * Accept baselines * Code review commments * Respond to code review comments

Author: mhegazy

src/compiler/checker.ts

@@ -226,6 +226,23 @@ namespace ts {
  return tryFindAmbientModule(moduleName, /*withAugmentations*/ false);
  },
  getApparentType,
+ getUnionType,
+ createAnonymousType,
+ createSignature,
+ createSymbol,
+ createIndexInfo,
+ getAnyType: () => anyType,
+ getStringType: () => stringType,
+ getNumberType: () => numberType,
+ createPromiseType,
+ createArrayType,
+ getBooleanType: () => booleanType,
+ getVoidType: () => voidType,
+ getUndefinedType: () => undefinedType,
+ getNullType: () => nullType,
+ getESSymbolType: () => esSymbolType,
+ getNeverType: () => neverType,
+ isSymbolAccessible,
  isArrayLikeType,
  getAllPossiblePropertiesOfTypes,
  getSuggestionForNonexistentProperty: (node, type) => getSuggestionForNonexistentProperty(node, type),
@@ -3675,6 +3692,7 @@ namespace ts {
 
  function buildParameterDisplay(p: Symbol, writer: SymbolWriter, enclosingDeclaration?: Node, flags?: TypeFormatFlags, symbolStack?: Symbol[]) {
  const parameterNode = <ParameterDeclaration>p.valueDeclaration;
+
  if (parameterNode ? isRestParameter(parameterNode) : isTransientSymbol(p) && p.isRestParameter) {
  writePunctuation(writer, SyntaxKind.DotDotDotToken);
  }

src/compiler/core.ts

@@ -213,11 +213,13 @@ namespace ts {
  return undefined;
  }
 
- export function zipWith<T, U>(arrayA: ReadonlyArray<T>, arrayB: ReadonlyArray<U>, callback: (a: T, b: U, index: number) => void): void {
+ export function zipWith<T, U, V>(arrayA: ReadonlyArray<T>, arrayB: ReadonlyArray<U>, callback: (a: T, b: U, index: number) => V): V[] {
+ const result: V[] = [];
  Debug.assert(arrayA.length === arrayB.length);
  for (let i = 0; i < arrayA.length; i++) {
- callback(arrayA[i], arrayB[i], i);
+ result.push(callback(arrayA[i], arrayB[i], i));
  }
+ return result;
  }
 
  export function zipToMap<T>(keys: ReadonlyArray<string>, values: ReadonlyArray<T>): Map<T> {

src/compiler/diagnosticMessages.json

@@ -3681,6 +3681,7 @@
  "category": "Message",
  "code": 90017
  },
+
  "Disable checking for this file.": {
  "category": "Message",
  "code": 90018
@@ -3725,7 +3726,6 @@
  "category": "Message",
  "code": 90028
  },
-
  "Convert function to an ES2015 class": {
  "category": "Message",
  "code": 95001
@@ -3734,34 +3734,36 @@
  "category": "Message",
  "code": 95002
  },
-
  "Extract symbol": {
  "category": "Message",
  "code": 95003
  },
-
  "Extract to {0} in {1}": {
  "category": "Message",
  "code": 95004
  },
-
  "Extract function": {
  "category": "Message",
  "code": 95005
  },
-
  "Extract constant": {
  "category": "Message",
  "code": 95006
  },
-
  "Extract to {0} in enclosing scope": {
  "category": "Message",
  "code": 95007
  },
-
  "Extract to {0} in {1} scope": {
  "category": "Message",
  "code": 95008
+ },
+ "Infer type of '{0}' from usage.": {
+ "category": "Message",
+ "code": 95009
+ },
+ "Infer parameter types from usage.": {
+ "category": "Message",
+ "code": 95010
  }
 }

src/compiler/types.ts

@@ -2695,6 +2695,24 @@ namespace ts {
  getSuggestionForNonexistentSymbol(location: Node, name: string, meaning: SymbolFlags): string | undefined;
  /* @internal */ getBaseConstraintOfType(type: Type): Type | undefined;
 
+ /* @internal */ getAnyType(): Type;
+ /* @internal */ getStringType(): Type;
+ /* @internal */ getNumberType(): Type;
+ /* @internal */ getBooleanType(): Type;
+ /* @internal */ getVoidType(): Type;
+ /* @internal */ getUndefinedType(): Type;
+ /* @internal */ getNullType(): Type;
+ /* @internal */ getESSymbolType(): Type;
+ /* @internal */ getNeverType(): Type;
+ /* @internal */ getUnionType(types: Type[], subtypeReduction?: boolean): Type;
+ /* @internal */ createArrayType(elementType: Type): Type;
+ /* @internal */ createPromiseType(type: Type): Type;
+
+ /* @internal */ createAnonymousType(symbol: Symbol, members: SymbolTable, callSignatures: Signature[], constructSignatures: Signature[], stringIndexInfo: IndexInfo, numberIndexInfo: IndexInfo): Type;
+ /* @internal */ createSignature(declaration: SignatureDeclaration, typeParameters: TypeParameter[], thisParameter: Symbol | undefined, parameters: Symbol[], resolvedReturnType: Type, typePredicate: TypePredicate, minArgumentCount: number, hasRestParameter: boolean, hasLiteralTypes: boolean): Signature;
+ /* @internal */ createSymbol(flags: SymbolFlags, name: __String): TransientSymbol;
+ /* @internal */ createIndexInfo(type: Type, isReadonly: boolean, declaration?: SignatureDeclaration): IndexInfo;
+ /* @internal */ isSymbolAccessible(symbol: Symbol, enclosingDeclaration: Node, meaning: SymbolFlags, shouldComputeAliasToMarkVisible: boolean): SymbolAccessibilityResult;
  /* @internal */ tryFindAmbientModuleWithoutAugmentations(moduleName: string): Symbol | undefined;
 
  /* @internal */ getSymbolWalker(accept?: (symbol: Symbol) => boolean): SymbolWalker;

src/compiler/utilities.ts

@@ -5649,6 +5649,14 @@ namespace ts {
  return node.kind >= SyntaxKind.FirstJSDocTagNode && node.kind <= SyntaxKind.LastJSDocTagNode;
  }
 
+ export function isSetAccessor(node: Node): node is SetAccessorDeclaration {
+ return node.kind === SyntaxKind.SetAccessor;
+ }
+
+ export function isGetAccessor(node: Node): node is GetAccessorDeclaration {
+ return node.kind === SyntaxKind.GetAccessor;
+ }
+
  /** True if has jsdoc nodes attached to it. */
  /* @internal */
  export function hasJSDocNodes(node: Node): node is HasJSDoc {

src/services/codefixes/fixes.ts

@@ -13,3 +13,4 @@
 /// <reference path='importFixes.ts' />
 /// <reference path='disableJsDiagnostics.ts' />
 /// <reference path='helpers.ts' />
+/// <reference path='inferFromUsage.ts' />