Skip to content

Commit b52672d

Browse files
committed
Replaced deprecated TestCase methods. Refs django#17049.
1 parent e84f79f commit b52672d

File tree

19 files changed

+80
-80
lines changed

19 files changed

+80
-80
lines changed

django/contrib/auth/tests/management.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def test_that_changepassword_command_changes_joes_password(self):
5050
command.execute("joe", stdout=self.stdout)
5151
command_output = self.stdout.getvalue().strip()
5252

53-
self.assertEquals(command_output, "Changing password for user 'joe'\nPassword changed successfully for user 'joe'")
53+
self.assertEqual(command_output, "Changing password for user 'joe'\nPassword changed successfully for user 'joe'")
5454
self.assertTrue(models.User.objects.get(username="joe").check_password("not qwerty"))
5555

5656
def test_that_max_tries_exits_1(self):

django/contrib/auth/tests/models.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,12 @@ class NaturalKeysTestCase(TestCase):
4646

4747
def test_user_natural_key(self):
4848
staff_user = User.objects.get(username='staff')
49-
self.assertEquals(User.objects.get_by_natural_key('staff'), staff_user)
50-
self.assertEquals(staff_user.natural_key(), ('staff',))
49+
self.assertEqual(User.objects.get_by_natural_key('staff'), staff_user)
50+
self.assertEqual(staff_user.natural_key(), ('staff',))
5151

5252
def test_group_natural_key(self):
5353
users_group = Group.objects.create(name='users')
54-
self.assertEquals(Group.objects.get_by_natural_key('users'), users_group)
54+
self.assertEqual(Group.objects.get_by_natural_key('users'), users_group)
5555

5656

5757
@override_settings(USE_TZ=False)
@@ -61,7 +61,7 @@ class LoadDataWithoutNaturalKeysTestCase(TestCase):
6161
def test_user_is_created_and_added_to_group(self):
6262
user = User.objects.get(username='my_username')
6363
group = Group.objects.get(name='my_group')
64-
self.assertEquals(group, user.groups.get())
64+
self.assertEqual(group, user.groups.get())
6565

6666

6767
@override_settings(USE_TZ=False)
@@ -71,31 +71,31 @@ class LoadDataWithNaturalKeysTestCase(TestCase):
7171
def test_user_is_created_and_added_to_group(self):
7272
user = User.objects.get(username='my_username')
7373
group = Group.objects.get(name='my_group')
74-
self.assertEquals(group, user.groups.get())
74+
self.assertEqual(group, user.groups.get())
7575

7676

7777
class UserManagerTestCase(TestCase):
7878

7979
def test_create_user(self):
8080
email_lowercase = 'normal@normal.com'
8181
user = User.objects.create_user('user', email_lowercase)
82-
self.assertEquals(user.email, email_lowercase)
83-
self.assertEquals(user.username, 'user')
84-
self.assertEquals(user.password, '!')
82+
self.assertEqual(user.email, email_lowercase)
83+
self.assertEqual(user.username, 'user')
84+
self.assertEqual(user.password, '!')
8585

8686
def test_create_user_email_domain_normalize_rfc3696(self):
8787
# According to http://tools.ietf.org/html/rfc3696#section-3
8888
# the "@" symbol can be part of the local part of an email address
8989
returned = UserManager.normalize_email(r'Abc\@DEF@EXAMPLE.com')
90-
self.assertEquals(returned, r'Abc\@DEF@example.com')
90+
self.assertEqual(returned, r'Abc\@DEF@example.com')
9191

9292
def test_create_user_email_domain_normalize(self):
9393
returned = UserManager.normalize_email('normal@DOMAIN.COM')
94-
self.assertEquals(returned, 'normal@domain.com')
94+
self.assertEqual(returned, 'normal@domain.com')
9595

9696
def test_create_user_email_domain_normalize_with_whitespace(self):
9797
returned = UserManager.normalize_email('email\ with_whitespace@D.COM')
98-
self.assertEquals(returned, 'email\ with_whitespace@d.com')
98+
self.assertEqual(returned, 'email\ with_whitespace@d.com')
9999

100100
def test_empty_username(self):
101101
self.assertRaisesMessage(ValueError,

django/contrib/formtools/tests/wizard/wizardtests/tests.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ def get_context_data(self, **kwargs):
303303
view = TestWizard.as_view([forms.Form])
304304

305305
response = view(factory.get('/'))
306-
self.assertEquals(response.context_data['test_key'], 'test_value')
306+
self.assertEqual(response.context_data['test_key'], 'test_value')
307307

308308
def test_get_context_data_with_mixin(self):
309309
class AnotherMixin(object):
@@ -329,8 +329,8 @@ def get_context_data(self, **kwargs):
329329
view = TestWizard.as_view([forms.Form])
330330

331331
response = view(factory.get('/'))
332-
self.assertEquals(response.context_data['test_key'], 'test_value')
333-
self.assertEquals(response.context_data['another_key'], 'another_value')
332+
self.assertEqual(response.context_data['test_key'], 'test_value')
333+
self.assertEqual(response.context_data['another_key'], 'another_value')
334334

335335

336336
class WizardFormKwargsOverrideTests(TestCase):

django/contrib/gis/geoip/tests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def test04_city(self):
8787
self.assertEqual('TX', d['region'])
8888
self.assertEqual(713, d['area_code'])
8989
geom = g.geos(query)
90-
self.failIf(not isinstance(geom, GEOSGeometry))
90+
self.assertTrue(isinstance(geom, GEOSGeometry))
9191
lon, lat = (-95.4010, 29.7079)
9292
lat_lon = g.lat_lon(query)
9393
lat_lon = (lat_lon[1], lat_lon[0])

django/contrib/gis/tests/test_measure.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def testAccess(self):
4545
def testAccessInvalid(self):
4646
"Testing access in invalid units"
4747
d = D(m=100)
48-
self.failIf(hasattr(d, 'banana'))
48+
self.assertFalse(hasattr(d, 'banana'))
4949

5050
def testAddition(self):
5151
"Test addition & subtraction"
@@ -133,7 +133,7 @@ def testComparisons(self):
133133
self.assertTrue(d2 > d1)
134134
self.assertTrue(d1 == d1)
135135
self.assertTrue(d1 < d2)
136-
self.failIf(d3)
136+
self.assertFalse(d3)
137137

138138
def testUnitsStr(self):
139139
"Testing conversion to strings"
@@ -179,7 +179,7 @@ def testAccess(self):
179179
def testAccessInvaliA(self):
180180
"Testing access in invalid units"
181181
a = A(sq_m=100)
182-
self.failIf(hasattr(a, 'banana'))
182+
self.assertFalse(hasattr(a, 'banana'))
183183

184184
def testAddition(self):
185185
"Test addition & subtraction"
@@ -267,7 +267,7 @@ def testComparisons(self):
267267
self.assertTrue(a2 > a1)
268268
self.assertTrue(a1 == a1)
269269
self.assertTrue(a1 < a2)
270-
self.failIf(a3)
270+
self.assertFalse(a3)
271271

272272
def testUnitsStr(self):
273273
"Testing conversion to strings"

tests/modeltests/prefetch_related/tests.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ def test_foreignkey(self):
341341
qs = AuthorWithAge.objects.prefetch_related('addresses')
342342
addresses = [[unicode(address) for address in obj.addresses.all()]
343343
for obj in qs]
344-
self.assertEquals(addresses, [[unicode(self.authorAddress)], [], []])
344+
self.assertEqual(addresses, [[unicode(self.authorAddress)], [], []])
345345

346346
def test_m2m_to_inheriting_model(self):
347347
qs = AuthorWithAge.objects.prefetch_related('books_with_year')
@@ -351,7 +351,7 @@ def test_m2m_to_inheriting_model(self):
351351
qs = AuthorWithAge.objects.all()
352352
lst2 = [[unicode(book) for book in author.books_with_year.all()]
353353
for author in qs]
354-
self.assertEquals(lst, lst2)
354+
self.assertEqual(lst, lst2)
355355

356356
qs = BookWithYear.objects.prefetch_related('aged_authors')
357357
with self.assertNumQueries(2):
@@ -360,7 +360,7 @@ def test_m2m_to_inheriting_model(self):
360360
qs = BookWithYear.objects.all()
361361
lst2 = [[unicode(author) for author in book.aged_authors.all()]
362362
for book in qs]
363-
self.assertEquals(lst, lst2)
363+
self.assertEqual(lst, lst2)
364364

365365
def test_parent_link_prefetch(self):
366366
with self.assertNumQueries(2):
@@ -402,7 +402,7 @@ def test_foreignkey(self):
402402
qs = Author.objects.prefetch_related('addresses')
403403
addresses = [[unicode(address) for address in obj.addresses.all()]
404404
for obj in qs]
405-
self.assertEquals(addresses, [[unicode(self.authorAddress)], [], []])
405+
self.assertEqual(addresses, [[unicode(self.authorAddress)], [], []])
406406

407407
def test_m2m(self):
408408
with self.assertNumQueries(3):
@@ -411,7 +411,7 @@ def test_m2m(self):
411411
[unicode(i_like) for i_like in author.favorite_authors.all()],
412412
[unicode(likes_me) for likes_me in author.favors_me.all()]
413413
) for author in qs]
414-
self.assertEquals(
414+
self.assertEqual(
415415
favorites,
416416
[
417417
([unicode(self.author2)],[unicode(self.author3)]),
@@ -549,7 +549,7 @@ def test_using_is_honored_m2m(self):
549549
authors = "".join(["%s: %s\n" %
550550
(author.name, ", ".join(b.title for b in author.books.all()))
551551
for author in qs2])
552-
self.assertEquals(authors,
552+
self.assertEqual(authors,
553553
"Charlotte: Poems, Jane Eyre\n"
554554
"Anne: Poems\n"
555555
"Emily: Poems, Wuthering Heights\n"

tests/modeltests/select_for_update/tests.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def has_for_update_sql(self, tested_connection, nowait=False):
8080
return bool(sql.find(for_update_sql) > -1)
8181

8282
def check_exc(self, exc):
83-
self.failUnless(isinstance(exc, DatabaseError))
83+
self.assertTrue(isinstance(exc, DatabaseError))
8484

8585
@skipUnlessDBFeature('has_select_for_update')
8686
def test_for_update_sql_generated(self):
@@ -217,7 +217,7 @@ def test_block(self):
217217

218218
# Check the thread has finished. Assuming it has, we should
219219
# find that it has updated the person's name.
220-
self.failIf(thread.isAlive())
220+
self.assertFalse(thread.isAlive())
221221

222222
# We must commit the transaction to ensure that MySQL gets a fresh read,
223223
# since by default it runs in REPEATABLE READ mode

tests/modeltests/test_client/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -378,15 +378,15 @@ def test_view_with_permissions_exception(self):
378378

379379
# Get the page without logging in. Should result in 403.
380380
response = self.client.get('/test_client/permission_protected_view_exception/')
381-
self.assertEquals(response.status_code, 403)
381+
self.assertEqual(response.status_code, 403)
382382

383383
# Log in
384384
login = self.client.login(username='testclient', password='password')
385385
self.assertTrue(login, 'Could not log in')
386386

387387
# Log in with wrong permissions. Should result in 403.
388388
response = self.client.get('/test_client/permission_protected_view_exception/')
389-
self.assertEquals(response.status_code, 403)
389+
self.assertEqual(response.status_code, 403)
390390

391391
def test_view_with_method_permissions(self):
392392
"Request a page that is protected with a @permission_required method"

tests/regressiontests/admin_filters/tests.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ def test_relatedfieldlistfilter_foreignkey(self):
270270

271271
# Make sure the last choice is None and is selected
272272
filterspec = changelist.get_filters(request)[0][1]
273-
self.assertEquals(force_unicode(filterspec.title), u'Verbose Author')
273+
self.assertEqual(force_unicode(filterspec.title), u'Verbose Author')
274274
choices = list(filterspec.choices(changelist))
275275
self.assertEqual(choices[-1]['selected'], True)
276276
self.assertEqual(choices[-1]['query_string'], '?author__isnull=True')
@@ -280,7 +280,7 @@ def test_relatedfieldlistfilter_foreignkey(self):
280280

281281
# Make sure the correct choice is selected
282282
filterspec = changelist.get_filters(request)[0][1]
283-
self.assertEquals(force_unicode(filterspec.title), u'Verbose Author')
283+
self.assertEqual(force_unicode(filterspec.title), u'Verbose Author')
284284
# order of choices depends on User model, which has no order
285285
choice = select_by(filterspec.choices(changelist), "display", "alfred")
286286
self.assertEqual(choice['selected'], True)
@@ -298,7 +298,7 @@ def test_relatedfieldlistfilter_manytomany(self):
298298

299299
# Make sure the last choice is None and is selected
300300
filterspec = changelist.get_filters(request)[0][2]
301-
self.assertEquals(force_unicode(filterspec.title), u'Verbose Contributors')
301+
self.assertEqual(force_unicode(filterspec.title), u'Verbose Contributors')
302302
choices = list(filterspec.choices(changelist))
303303
self.assertEqual(choices[-1]['selected'], True)
304304
self.assertEqual(choices[-1]['query_string'], '?contributors__isnull=True')
@@ -308,7 +308,7 @@ def test_relatedfieldlistfilter_manytomany(self):
308308

309309
# Make sure the correct choice is selected
310310
filterspec = changelist.get_filters(request)[0][2]
311-
self.assertEquals(force_unicode(filterspec.title), u'Verbose Contributors')
311+
self.assertEqual(force_unicode(filterspec.title), u'Verbose Contributors')
312312
choice = select_by(filterspec.choices(changelist), "display", "bob")
313313
self.assertEqual(choice['selected'], True)
314314
self.assertEqual(choice['query_string'], '?contributors__id__exact=%d' % self.bob.pk)
@@ -509,7 +509,7 @@ def test_simplelistfilter(self):
509509
self.assertEqual(choices[3]['query_string'], '?publication-decade=the+00s&author__id__exact=%s' % self.alfred.pk)
510510

511511
filterspec = changelist.get_filters(request)[0][0]
512-
self.assertEquals(force_unicode(filterspec.title), u'Verbose Author')
512+
self.assertEqual(force_unicode(filterspec.title), u'Verbose Author')
513513
choice = select_by(filterspec.choices(changelist), "display", "alfred")
514514
self.assertEqual(choice['selected'], True)
515515
self.assertEqual(choice['query_string'], '?publication-decade=the+00s&author__id__exact=%s' % self.alfred.pk)

tests/regressiontests/admin_inlines/tests.py

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -405,39 +405,39 @@ def test_add_inlines(self):
405405

406406
# Check that there's only one inline to start with and that it has the
407407
# correct ID.
408-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
408+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
409409
'.dynamic-profile_set')), 1)
410-
self.failUnlessEqual(self.selenium.find_elements_by_css_selector(
410+
self.assertEqual(self.selenium.find_elements_by_css_selector(
411411
'.dynamic-profile_set')[0].get_attribute('id'),
412412
'profile_set-0')
413-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
413+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
414414
'.dynamic-profile_set#profile_set-0 input[name=profile_set-0-first_name]')), 1)
415-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
415+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
416416
'.dynamic-profile_set#profile_set-0 input[name=profile_set-0-last_name]')), 1)
417417

418418
# Add an inline
419419
self.selenium.find_element_by_link_text('Add another Profile').click()
420420

421421
# Check that the inline has been added, that it has the right id, and
422422
# that it contains the right fields.
423-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
423+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
424424
'.dynamic-profile_set')), 2)
425-
self.failUnlessEqual(self.selenium.find_elements_by_css_selector(
425+
self.assertEqual(self.selenium.find_elements_by_css_selector(
426426
'.dynamic-profile_set')[1].get_attribute('id'), 'profile_set-1')
427-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
427+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
428428
'.dynamic-profile_set#profile_set-1 input[name=profile_set-1-first_name]')), 1)
429-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
429+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
430430
'.dynamic-profile_set#profile_set-1 input[name=profile_set-1-last_name]')), 1)
431431

432432
# Let's add another one to be sure
433433
self.selenium.find_element_by_link_text('Add another Profile').click()
434-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
434+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
435435
'.dynamic-profile_set')), 3)
436-
self.failUnlessEqual(self.selenium.find_elements_by_css_selector(
436+
self.assertEqual(self.selenium.find_elements_by_css_selector(
437437
'.dynamic-profile_set')[2].get_attribute('id'), 'profile_set-2')
438-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
438+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
439439
'.dynamic-profile_set#profile_set-2 input[name=profile_set-2-first_name]')), 1)
440-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
440+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
441441
'.dynamic-profile_set#profile_set-2 input[name=profile_set-2-last_name]')), 1)
442442

443443
# Enter some data and click 'Save'
@@ -473,17 +473,17 @@ def test_delete_inlines(self):
473473
self.selenium.find_element_by_link_text('Add another Profile').click()
474474
self.selenium.find_element_by_link_text('Add another Profile').click()
475475
self.selenium.find_element_by_link_text('Add another Profile').click()
476-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
476+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
477477
'#profile_set-group table tr.dynamic-profile_set')), 5)
478-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
478+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
479479
'form#profilecollection_form tr.dynamic-profile_set#profile_set-0')), 1)
480-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
480+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
481481
'form#profilecollection_form tr.dynamic-profile_set#profile_set-1')), 1)
482-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
482+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
483483
'form#profilecollection_form tr.dynamic-profile_set#profile_set-2')), 1)
484-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
484+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
485485
'form#profilecollection_form tr.dynamic-profile_set#profile_set-3')), 1)
486-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
486+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
487487
'form#profilecollection_form tr.dynamic-profile_set#profile_set-4')), 1)
488488

489489
# Click on a few delete buttons
@@ -492,13 +492,13 @@ def test_delete_inlines(self):
492492
self.selenium.find_element_by_css_selector(
493493
'form#profilecollection_form tr.dynamic-profile_set#profile_set-2 td.delete a').click()
494494
# Verify that they're gone and that the IDs have been re-sequenced
495-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
495+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
496496
'#profile_set-group table tr.dynamic-profile_set')), 3)
497-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
497+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
498498
'form#profilecollection_form tr.dynamic-profile_set#profile_set-0')), 1)
499-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
499+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
500500
'form#profilecollection_form tr.dynamic-profile_set#profile_set-1')), 1)
501-
self.failUnlessEqual(len(self.selenium.find_elements_by_css_selector(
501+
self.assertEqual(len(self.selenium.find_elements_by_css_selector(
502502
'form#profilecollection_form tr.dynamic-profile_set#profile_set-2')), 1)
503503

504504

0 commit comments

Comments
 (0)