This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Improve zeroing of RoomList notification badges #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Use an action and force an update when zeroing the number of notifications in a room. This is better than waiting for a `render` to happen at some point. This will hopefully fix element-hq/element-web#3257
dbkr reviewed Mar 28, 2017
| if (this.isAtEndOfLiveTimeline()) { | ||
| this.props.timelineSet.room.setUnreadNotificationCount('total', 0); | ||
| this.props.timelineSet.room.setUnreadNotificationCount('highlight', 0); | ||
| // XXX: i'm a bit surprised we don't have to emit an event or dispatch to get this picked up |
Member
There was a problem hiding this comment.
What I would do here is keep the setUnreadNotificationCount here and just forceUpdate when the dispatch is caught, otherwise you risk setUnreadNotificationCount happening twice if many things want to handle the dispatch.
By not sending the room with the action, we prevent its state from being updated by registered views listening for on_room_read
dbkr approved these changes Mar 28, 2017
martindale pushed a commit to FabricLabs/matrix-react-sdk that referenced this pull request Dec 8, 2018
Remove the request-only stuff we don't need anymore
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Use an action and force an update when zeroing the number of notifications in a room. This is better than waiting for a
renderto happen at some point. This will probably not fix element-hq/element-web#3257