first cut of improving UX for deleting devices. #717
Conversation
This adds a 5 minute auth cache to speed up the process of deleting old devices. It has the following nastinesses (mainly due to being written on a flight whilst juggling kids): * the auth cache is done as context attached to MatrixChat. one could argue that it should be per-client instead, but we don't yet have multiple clients. * the auth cache is only maintained currently in DevicesPanelEntry (i.e. set & invalidated). One could argue that it might be better maintained in InteractiveAuth.js or a dedicated cache object abstraction, but given the only use I can think of is when managing devices, perhaps this is good enough for now.
| this is for element-hq/element-web#2464 |
you could attach it to the LoggedInView (?) instead, which would solve that problem, as well as the one of secretly persisting your auth credentials over a logout/login cycle? |
| import MatrixClientPeg from '../../../MatrixClientPeg'; | ||
| import Modal from '../../../Modal'; | ||
| import DateUtils from '../../../DateUtils'; | ||
| import utils from 'matrix-js-sdk/lib/utils'; |
| in fact this seems quite a nice solution! |
| I have moved the cache to LoggedInView to fix the stupid "persist over logout" problem; thanks. However, i don't think this fixes support for multiple clients in future, given i'd assume that we'd implement multiple clients similar to how Console/iOS and Android did it: i.e. mux all the rooms together into a single UI (perhaps tagged into separate groups per account). So we'd definitely need to somehow anchor the cache to MatrixClient when we get there - perhaps even pushing it into js-sdk for simplicity. I don't think that should block this iteration though. @richvdh ptal |
sorry, I didn't mean to imply it would. It just felt like a more natural place to anchor it. |
| import MatrixClientPeg from '../../../MatrixClientPeg'; | ||
| import Modal from '../../../Modal'; | ||
| import DateUtils from '../../../DateUtils'; | ||
| import utils from 'matrix-js-sdk/lib/utils'; |
This adds a 5 minute auth cache to speed up the process of deleting
old devices. It has the following nastinesses (mainly due to being
written on a flight whilst juggling kids):
one could argue that it should be per-client instead, but we don't
yet have multiple clients.
(i.e. set & invalidated). One could argue that it might be better
maintained in InteractiveAuth.js or a dedicated cache object
abstraction, but given the only use I can think of is when managing
devices, perhaps this is good enough for now.