This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Display avatar initials in typing notifications #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
It seems they don't overlap hawkwawdly anymore, so this displays them always. Fixes element-hq/element-web#3084
dbkr approved these changes Feb 15, 2017
Contributor Author
| @dbkr seems like those test failures are unrelated?... bit weird though |
Contributor Author
| Don't merge just yet, I'd like to do some further testing as I think I spotted some avatars overlapping incorrectly. |
lukebarnard1 pushed a commit to element-hq/element-web that referenced this pull request Feb 16, 2017
This seemingly doesn't do anything and upsets things when avatars overlap (i.e. for the new typing avatars). See matrix-org/matrix-react-sdk#699
Contributor Author
| This seems to work with the CSS removal referenced |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It seems they don't overlap hawkwardly anymore, so this displays them always.
Fixes element-hq/element-web#3084