Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@lukebarnard1
Copy link
Contributor

No description provided.

@lukebarnard1 lukebarnard1 requested a review from dbkr February 10, 2017 11:33
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, lgtm


// Persist the team token across refreshes
if (this.props.startingFragmentQueryParams.team_token) {
window.sessionStorage.setItem(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to comment that yes, we do mean session storage here, for when I completely forget the conversation we had :p

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea :)

@lukebarnard1 lukebarnard1 merged commit a5a43bc into develop Feb 10, 2017
@lukebarnard1 lukebarnard1 deleted the luke/rts-session-team-token branch February 10, 2017 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants