This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Stop requesting null next replies from the server #6203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
A recent change (47e007e) introduced a regression where we failed to check whether a reply thread has a next reply. This meant that we would end up sending `/context/undefined` requests to the server for every reply thread on every room view. Fixes element-hq/element-web#17563 Regressed by #6079
germain-gg approved these changes Jun 16, 2021
Contributor
germain-gg left a comment
germain-gg left a comment There was a problem hiding this comment.
Thank you for investigating this 🙏
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
A recent change (47e007e) introduced a regression where we failed to check whether a reply thread has a next reply. This meant that we would end up sending
/context/undefinedrequests to the server for every reply thread on every room view.Fixes element-hq/element-web#17563
Regressed by #6079