Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@t3chguy
Copy link
Member

@t3chguy t3chguy commented Jun 16, 2021

@t3chguy t3chguy requested a review from a team June 16, 2021 10:49
@turt2live
Copy link
Member

Your CI is unhappy.

@t3chguy t3chguy changed the title Convert MultiInviter, RoomInvite and UserAddress to Typescript Improve invite error messages in InviteDialog for room invites Jun 16, 2021
@t3chguy
Copy link
Member Author

t3chguy commented Jun 16, 2021

Arg, the typescript return types are incorrect in js-sdk :(

@turt2live
Copy link
Member

this also probably needs design review? This is reverting the error message behaviour from last time.

@t3chguy t3chguy requested a review from a team June 16, 2021 19:13
Copy link
Contributor

@niquewoodhouse niquewoodhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@t3chguy t3chguy merged commit 7141490 into develop Jun 24, 2021
@t3chguy t3chguy deleted the t3chguy/fix/15051 branch June 24, 2021 10:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants