This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Don't let users accidentally redact ACL events #5384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixes element-hq/element-web#15633 Fixes element-hq/element-web#15632 Slightly more information is in the issues above and in the diff, however the short version is redacting an ACL event can obliterate a room which is bad.
turt2live added the X-Release-Blocker 
t3chguy approved these changes Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#15633
Fixes element-hq/element-web#15632
Slightly more information is in the issues above and in the diff, however the short version is redacting an ACL event can obliterate a room which is bad.