Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@dbkr
Copy link
Member

@dbkr dbkr commented Oct 19, 2020

No description provided.

@dbkr dbkr requested a review from a team October 19, 2020 13:58
this.play(AudioID.Ringback);
break;
case CallState.Ended:
Analytics.trackEvent('voip', 'callEnded', "hangupReason", call.hangupReason);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please consistent quotes within one line 🤢

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@dbkr dbkr merged commit ce47856 into develop Oct 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants