This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Make the ACL update message less noisy #5316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixes element-hq/element-web#14216 Copy is not reviewed as of writing.
Member
| Given that we're removing i18n strings, can we do our seldom run prunei18n :P? |
Member Author
| We're not removing any i18n strings. We're actually adding them here. |
Member
| Oh dear. I blindly thought the deleted changeset had i18n support :'( |
Member Author
| So did I when I ran |
jryans approved these changes Oct 14, 2020
Collaborator
| @turt2live Personally, this seems uncontroversial to me, so perhaps Design review is not needed...? This text is basically the same, just with server names removed. |
Member Author
| I'm happy to use that rationale - design might want to look at it still, but I suspect they would want to look at it regardless of these changes. |
Half-Shot reviewed Oct 15, 2020
| changes.push(`Participating from a server using an IP literal hostname is now ${allowban}.`); | ||
| // If we know for sure everyone is banned, mark the room as obliterated | ||
| if (current.allow.length === 0) { | ||
| return text + " " + _t("🎉 All servers are banned from participating! This room can no longer be used."); |
Contributor
There was a problem hiding this comment.
Glad the sarcastic 🎉 lives on
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#14216
Copy is not reviewed as of writing.
Instead of saying "TravisR has changed the server ACLs for this room: example.org is now banned", we can just leave it at "TravisR changed the server ACLs for this room."