This repository was archived by the owner on Sep 11, 2024. It is now read-only.
event-index: Pass the user/device id pair when initializing the event index. #5312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
t3chguy reviewed Oct 13, 2020
t3chguy reviewed Oct 13, 2020
t3chguy reviewed Oct 13, 2020
t3chguy reviewed Oct 13, 2020
t3chguy approved these changes Oct 13, 2020
Contributor Author
| @stoically will this mess up radicale-native? |
Contributor
| Seems non-breaking since the seshat API didn't change and the RN javascript part will just ignore the additional arguments (for now) - thanks for the heads-up! @poljar |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This extends the base event index manager to pass the user id and device id when initializing the event index, this is needed so we store the passphrase under a per user/device specific key.
This is a breaking change.
The element web part is found at element-hq/element-web#15455.
The element desktop part is found at element-hq/element-desktop#147.