This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Rewrite call state machine #5308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Remove the two separate enumerations of call state: now everything uses the js-sdk version of call state. Stop adding a separate 'call_state' field onto the call object(!) * Better reflection of the actual state of the call in the call bar, so when it's connecting, it says connecting, and only says 'active call' when the call is actually active. * More typey goodness
turt2live suggested changes Oct 9, 2020
Member
turt2live left a comment
turt2live left a comment There was a problem hiding this comment.
generally lgtm, though most of my review can be summarized as: enum
turt2live approved these changes Oct 12, 2020
Member
turt2live left a comment
turt2live left a comment There was a problem hiding this comment.
lgtm - would be good to get a comment on the block just because it's a relatively unexpected thing in our codebase
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
uses the js-sdk version of call state. Stop adding a separate
'call_state' field onto the call object(!)
so when it's connecting, it says connecting, and only says 'active call'
when the call is actually active.
Requires matrix-org/matrix-js-sdk#1503