This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Convert auth lifecycle to TS, remove dead ILAG code #5296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
TypeScript helpfully pointed me towards this dead code, which has been floating around unused for a while. If we want to bring back ILAG in the future, we can always revive it from history.
t3chguy approved these changes Oct 7, 2020
Member
t3chguy left a comment
t3chguy left a comment There was a problem hiding this comment.
Looks great otherwise, should we hold this until after the RC just to be triply-safe?
Collaborator Author
Ah yeah, probably a good idea. |
Collaborator Author
| The CI results no longer match reality, so I'll try just merging... 😱 |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Login.jsandLifecycle.jsto TSPart of element-hq/element-web#15350