Skip to content

Commit cd30a65

Browse files
committed
fix multicast, lint
1 parent 1c2aa47 commit cd30a65

File tree

5 files changed

+563
-71
lines changed

5 files changed

+563
-71
lines changed

.eslintrc.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
module.exports = {
2+
"extends": "standard",
3+
"plugins": [
4+
"standard",
5+
"promise"
6+
]
7+
};

package.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@
1717
"watch": "npm run build && ava test --verbose --watch",
1818
"build": "babel src -d build",
1919
"dev": "nodemon --exec NODE_ENV=development babel-node src/index.js",
20-
"start": "npm run build && NODE_ENV=production node build/index.js"
20+
"start": "npm run build && NODE_ENV=production node build/index.js",
21+
"lint": "eslint src",
22+
"lint:fix": "eslint --fix src"
2123
},
2224
"author": "Muhammad Mustadi <muhammad.mustadi@gmail.com> (http://mustadi.xyz)",
2325
"license": "MIT",
@@ -38,6 +40,10 @@
3840
"babel-cli": "^6.16.0",
3941
"babel-preset-es2015": "^6.16.0",
4042
"babel-preset-stage-3": "^6.17.0",
43+
"eslint": "^3.18.0",
44+
"eslint-config-standard": "^7.1.0",
45+
"eslint-plugin-promise": "^3.5.0",
46+
"eslint-plugin-standard": "^2.1.1",
4147
"nodemon": "^1.11.0"
4248
},
4349
"ava": {

src/bot.js

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ const _sourceTypes = ['user', 'group', 'room']
1010
const _baseUrl = 'https://api.line.me'
1111

1212
export default class LineBot extends EventEmitter {
13-
1413
static get eventTypes () {
1514
return _eventTypes
1615
}
@@ -59,7 +58,7 @@ export default class LineBot extends EventEmitter {
5958
url: _baseUrl + path,
6059
data: payload || {}
6160
}
62-
if (type == 'content') opts.responseType = 'arraybuffer';
61+
if (type === 'content') opts.responseType = 'arraybuffer'
6362
return axios(opts).catch(err => err.response)
6463
}
6564

@@ -127,33 +126,33 @@ export default class LineBot extends EventEmitter {
127126
pushMessage (channel, messages) {
128127
const pushEndpoint = '/v2/bot/message/push'
129128
messages = Array.isArray(messages) ? messages : [messages]
130-
if (messages.length < 1 || messages.length > 5) return Promise.reject(`Invalid messages length. (1 - 5), the message was ${messages.length}`)
129+
if (messages.length < 1 || messages.length > 5) return Promise.reject(Error(`Invalid messages length. (1 - 5), the message was ${messages.length}`))
131130
let payload = {
132131
to: channel,
133132
messages: messages
134133
}
135134
return this._request('post', pushEndpoint, payload)
136135
}
137136

138-
multicast(channels, messages) {
137+
multicast (channels, messages) {
139138
const multicastEndpoint = '/v2/bot/message/multicast'
140-
if (!channels) return Promise.reject({error: {message: 'you must supply valid channels'}})
141-
if (!messages) return Promise.reject({error: {message: 'you must supply messages to push'}})
139+
if (!channels) return Promise.reject(Error('you must supply valid channels'))
140+
if (!messages) return Promise.reject(Error('you must supply messages to push'))
142141
messages = Array.isArray(messages) ? messages : [messages]
143142
channels = Array.isArray(channels) ? channels : [channels]
144-
if (messages.length < 1 || messages.length > 5) return Promise.reject(`Invalid messages length. (1 - 5), the message was ${messages.length}`)
145-
if (channels.length < 1 || channels.length > 150) return Promise.reject(`Invalid channels length. (1 - 150), the recipients were too many (${channels.length})`)
143+
if (messages.length < 1 || messages.length > 5) return Promise.reject(Error(`Invalid messages length. (1 - 5), the message was ${messages.length}`))
144+
if (channels.length < 1 || channels.length > 150) return Promise.reject(Error(`Invalid channels length. (1 - 150), the recipients were too many (${channels.length})`))
146145
let payload = {
147-
to: channel,
146+
to: channels,
148147
messages: messages
149148
}
150-
return this._request('post', pushEndpoint, payload)
149+
return this._request('post', multicastEndpoint, payload)
151150
}
152151

153152
replyMessage (replyToken, messages) {
154153
const replyEndpoint = '/v2/bot/message/reply'
155154
messages = Array.isArray(messages) ? messages : [messages]
156-
if (messages.length < 1 || messages.length > 5) return Promise.reject(`Invalid messages length. (1 - 5), the message was ${messages.length}`)
155+
if (messages.length < 1 || messages.length > 5) return Promise.reject(Error(`Invalid messages length. (1 - 5), the message was ${messages.length}`))
157156
let payload = {
158157
replyToken: replyToken,
159158
messages: messages
@@ -162,20 +161,20 @@ export default class LineBot extends EventEmitter {
162161
}
163162

164163
getContent (messageId) {
165-
if (!messageId || typeof messageId !== 'string') return Promise.reject('No message Id.')
164+
if (!messageId || typeof messageId !== 'string') return Promise.reject(Error('No message Id.'))
166165
const contentEndpoint = `/v2/bot/message/${messageId}/content`
167166
return this._request('get', contentEndpoint, null, 'content')
168167
}
169168

170169
getProfile (userId) {
171-
if (!userId || typeof userId !== 'string') return Promise.reject('No user Id.')
170+
if (!userId || typeof userId !== 'string') return Promise.reject(Error('No user Id.'))
172171
const profileEndpoint = `/v2/bot/profile/${userId}`
173172
return this._request('get', profileEndpoint, null)
174173
}
175174

176175
leaveChannel (channel) {
177176
let channelId = channel && (channel.groupId || channel.roomId)
178-
if (!channelId) return Promise.reject('No channel Id.')
177+
if (!channelId) return Promise.reject(Error('No channel Id.'))
179178
const leaveEndpoint = channel.groupId ? `/v2/bot/group/${channel}/leave` : `/v2/bot/room/${channel}/leave`
180179
return this._request('post', leaveEndpoint, null)
181180
}

src/webhook.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ class Webhook {
6464
})
6565
this.tunnel = tunnel
6666
})
67-
6867
}
6968

7069
_parseBody (req, res, next) {

0 commit comments

Comments
 (0)