Merge pull request #160 from basemate/develop

0.7.2.1 Release (Urgent Image Component Bug Fix Release)

Author: jonasjabari

CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## v0.7.2.1
+
+[Merged PRs](https://github.com/basemate/matestack-ui-core/milestone/5?closed=1)
+
+### Security Fixes
+
+- Dependency version bump (nokogiri) by dependabot
+
+### Bugfixes
+
+- Fixed image component 157 #158 by jonasjabari
+
 ## v0.7.2
 
 [Merged PRs](https://github.com/basemate/matestack-ui-core/milestone/4?closed=1)

Gemfile.lock

@@ -124,7 +124,7 @@ GEM
  mini_portile2 (2.4.0)
  minitest (5.11.3)
  nio4r (2.4.0)
- nokogiri (1.10.3)
+ nokogiri (1.10.4)
  mini_portile2 (~> 2.4.0)
  pipetree (0.1.1)
  poltergeist (1.18.1)

app/concepts/matestack/ui/core/img/img.haml

@@ -1 +1 @@
-= image_tag(@tag_attributes, ActionController::Base.helpers.asset_path(options[:path]), height: options[:height], width: options[:width], alt: options[:alt]])
+%img{@tag_attributes}

app/concepts/matestack/ui/core/img/img.rb

@@ -1,5 +1,14 @@
 module Matestack::Ui::Core::Img
  class Img < Matestack::Ui::Core::Component::Static
 
+ def setup
+ @tag_attributes.merge!({
+ src: ActionController::Base.helpers.asset_path(options[:path]),
+ height: options[:height],
+ width: options[:width],
+ alt: options[:alt]
+ })
+ end
+
  end
 end

lib/matestack/ui/core/version.rb

@@ -1,7 +1,7 @@
 module Matestack
  module Ui
  module Core
- VERSION = '0.7.2'
+ VERSION = '0.7.2.1'
  end
  end
 end

spec/dummy/app/assets/images/matestack-logo.png

@@ -0,0 +1,20 @@
+require_relative '../../support/utils'
+include Utils
+
+describe 'Img Component', type: :feature, js: true do
+
+ it 'Renders an image tag on the page' do
+
+ class ExamplePage < Matestack::Ui::Page
+ def response
+ components {
+ img path: 'matestack-logo.png', width: 500, height: 300, alt: "logo"
+ }
+ end
+ end
+
+ visit '/example'
+
+ expect(page).to have_xpath("//img[contains(@src,'matestack-logo') and @alt='logo' and @width='500' and @height='300']")
+ end
+end