This repository was archived by the owner on Jan 13, 2025. It is now read-only.
fix(textfield): hide filled-variant floating label at <52px #5553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
asyncliz changed the title asyncliz force-pushed the cl_292612246 branch 2 times, most recently from 9a0efd3 to 400a368 Compare 
| All 167 screenshot tests passed for commit 9a0efd3 vs. |
| All 167 screenshot tests passed for commit 400a368 vs. |
PiperOrigin-RevId: 292612246
asyncliz force-pushed the cl_292612246 branch from 400a368 to 3f753ad Compare 
asyncliz commented Feb 3, 2020
patrickrodee approved these changes Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Filled textfields will no longer show a floating label at certain densities. This can be overridden by setting
$mdc-text-field-minimum-height-for-filled-label: 40px.