This repository was archived by the owner on Jan 13, 2025. It is now read-only.
revert: fix(chips): Do not throw error if chip set becomes empty #5300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…)" This reverts commit f978109.
Codecov Report
@@ Coverage Diff @@ ## master #5300 +/- ## ========================================== - Coverage 98.63% 98.63% -0.01% ========================================== Files 122 122 Lines 5993 5991 -2 Branches 769 768 -1 ========================================== - Hits 5911 5909 -2 Misses 81 81 Partials 1 1
Continue to review full report at Codecov.
|
Collaborator
| All 731 screenshot tests passed for commit 719e03d vs. |
patrickrodee approved these changes Dec 3, 2019
abhiomkar changed the title 
| @abhiomkar @patrickrodee I just experienced this issue (opened in #5275) (example: https://jsfiddle.net/e872rdm6/). Would either of you be able to clarify why the fix was reverted? Is there an alternative that we should be using to avoid this error? |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reverts #5290