This repository was archived by the owner on Jan 13, 2025. It is now read-only.
fix(chips): Do not throw error if chip set becomes empty #5290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #5290 +/- ## ========================================== + Coverage 98.63% 98.63% +<.01% ========================================== Files 122 122 Lines 5991 5993 +2 Branches 768 769 +1 ========================================== + Hits 5909 5911 +2 Misses 81 81 Partials 1 1
Continue to review full report at Codecov.
|
Collaborator
| All 731 screenshot tests passed for commit f7c0794 vs. |
patrickrodee reviewed Dec 2, 2019
patrickrodee approved these changes Dec 2, 2019
Collaborator
| All 731 screenshot tests passed for commit 0215408 vs. |
abhiomkar added a commit that referenced this pull request Dec 3, 2019
…)" This reverts commit f978109.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #5275