feat(notched-outline): add feature targeting for styles #5289
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #5289 +/- ## ========================================== - Coverage 98.52% 98.49% -0.04% ========================================== Files 163 163 Lines 6309 6309 Branches 864 787 -77 ========================================== - Hits 6216 6214 -2 - Misses 93 95 +2
Continue to review full report at Codecov.
|
| } | ||
| | ||
| @mixin mdc-floating-label-float-position($positionY, $positionX: 0%, $scale: .75) { | ||
| @mixin mdc-floating-label-float-position($positionY, $positionX: 0%, $scale: .75, $query: mdc-feature-all()) { |
There was a problem hiding this comment.
I copied this change from #5287 since I needed it here and I didn't want to wait for the other PR to be merged. I'll rebase if necessary.
mmalerba left a comment
mmalerba left a comment There was a problem hiding this comment.
Looks good, can you provide a before and after diff of the emitted CSS?
Adds support for feature targeting to the `mdc-notched-outline` styles. Relates to material-components#4227.
| The files are identical @mmalerba. |
crisbeto force-pushed the notched-outline-feature-targeting branch from 452052c to 601344b Compare 
| I'll need to make some additional changes to our BUILD rule for Sass dependency changes and run some tests internally before I can merge this. Will do it on this week. Thanks! |
| Update: I manually tested all 3 PRs internally and ran a sanity test. Looks good so far! Will update here once global tests are complete. |
5 participants
Adds support for feature targeting to the
mdc-notched-outlinestyles.Relates to #4227.