Provide friendlier error for missing setup.py. (tox-dev#650)

* Provide friendlier error for missing setup.py * Added a test case for missing setup.py. Closes tox-dev#331.

Author: Volcyy

CONTRIBUTORS

@@ -24,6 +24,7 @@ Ionel Maries Cristian
 Ionel Maries Cristian
 Itxaka Serrano
 Jannis Leidel
+Johannes Christ
 Josh Smeaton
 Julian Krause
 Krisztian Fekete

changelog/331.misc.rst

@@ -0,0 +1 @@
+Running ``tox`` without a ``setup.py`` now has a more friendly error message and gives troubleshooting suggestions - by @Volcyy.

tests/test_z_cmdline.py

@@ -1,3 +1,4 @@
+import os
 import platform
 
 import py
@@ -454,6 +455,21 @@ def test_sdist_fails(cmd, initproj):
  ])
 
 
+def test_no_setup_py_exits(cmd, initproj):
+ initproj("pkg123-0.7", filedefs={
+ 'tox.ini': """
+ [testenv]
+ commands=python -c "2 + 2"
+ """
+ })
+ os.remove("setup.py")
+ result = cmd.run("tox", )
+ assert result.ret
+ result.stdout.fnmatch_lines([
+ "*ERROR*No setup.py file found*"
+ ])
+
+
 def test_package_install_fails(cmd, initproj):
  initproj("pkg123-0.7", filedefs={
  'tests': {'test_hello.py': "def test_hello(): pass"},

tox/session.py

@@ -403,7 +403,17 @@ def _copyfiles(self, srcdir, pathlist, destdir):
  def _makesdist(self):
  setup = self.config.setupdir.join("setup.py")
  if not setup.check():
- raise tox.exception.MissingFile(setup)
+ self.report.error(
+ "No setup.py file found. The expected location is:\n"
+ " %s\n"
+ "You can\n"
+ " 1. Create one:\n"
+ " https://packaging.python.org/tutorials/distributing-packages/#setup-py\n"
+ " 2. Configure tox to avoid running sdist:\n"
+ " http://tox.readthedocs.io/en/latest/example/general.html"
+ "#avoiding-expensive-sdist" % setup
+ )
+ raise SystemExit(1)
  action = self.newaction(None, "packaging")
  with action:
  action.setactivity("sdist-make", setup)