merged branch fabpot/removed-unused-code (PR symfony#8440)

This PR was merged into the 2.3 branch. Discussion ---------- removed unused code | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- c60bdf5 removed unused code

Author: fabpot

src/Symfony/Bridge/Doctrine/DependencyInjection/CompilerPass/RegisterMappingsPass.php

@@ -12,7 +12,6 @@
 namespace Symfony\Bridge\Doctrine\DependencyInjection\CompilerPass;
 
 use Symfony\Component\DependencyInjection\Exception\ParameterNotFoundException;
-
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\DependencyInjection\Reference;

src/Symfony/Component/Intl/Util/IntlTestHelper.php

@@ -39,11 +39,11 @@ public static function requireIntl(\PhpUnit_Framework_TestCase $testCase)
  // * the intl extension is loaded with version Intl::getIcuStubVersion()
  // * the intl extension is not loaded
 
- if (IcuVersion::compare(Intl::getIcuVersion(), Intl::getIcuStubVersion(), '!=', $precision = 1)) {
+ if (IcuVersion::compare(Intl::getIcuVersion(), Intl::getIcuStubVersion(), '!=', 1)) {
  $testCase->markTestSkipped('Please change ICU version to ' . Intl::getIcuStubVersion());
  }
 
- if (IcuVersion::compare(Intl::getIcuDataVersion(), Intl::getIcuStubVersion(), '!=', $precision = 1)) {
+ if (IcuVersion::compare(Intl::getIcuDataVersion(), Intl::getIcuStubVersion(), '!=', 1)) {
  $testCase->markTestSkipped('Please change the Icu component to version 1.0.x or 1.' . IcuVersion::normalize(Intl::getIcuStubVersion(), 1) . '.x');
  }
 
@@ -75,12 +75,12 @@ public static function requireFullIntl(\PhpUnit_Framework_TestCase $testCase)
  }
 
  // ... and only if the version is *one specific version* ...
- if (IcuVersion::compare(Intl::getIcuVersion(), Intl::getIcuStubVersion(), '!=', $precision = 1)) {
+ if (IcuVersion::compare(Intl::getIcuVersion(), Intl::getIcuStubVersion(), '!=', 1)) {
  $testCase->markTestSkipped('Please change ICU version to ' . Intl::getIcuStubVersion());
  }
 
  // ... and only if the data in the Icu component matches that version.
- if (IcuVersion::compare(Intl::getIcuDataVersion(), Intl::getIcuStubVersion(), '!=', $precision = 1)) {
+ if (IcuVersion::compare(Intl::getIcuDataVersion(), Intl::getIcuStubVersion(), '!=', 1)) {
  $testCase->markTestSkipped('Please change the Icu component to version 1.0.x or 1.' . IcuVersion::normalize(Intl::getIcuStubVersion(), 1) . '.x');
  }