[misc] permit getString on a binary object

Author: diego Dupin

src/main/java/org/mariadb/jdbc/plugin/codec/StringCodec.java

@@ -87,17 +87,6 @@ public String decodeText(
  sb.append("'");
  return sb.toString();
 
- case BLOB:
- case TINYBLOB:
- case MEDIUMBLOB:
- case LONGBLOB:
- if (column.isBinary()) {
- buf.skip(length);
- throw new SQLDataException(
- String.format("Data type %s cannot be decoded as String", column.getType()));
- }
- return buf.readString(length);
-
  default:
  return buf.readString(length);
  }
@@ -253,17 +242,6 @@ public String decodeBinary(
  DateTimeFormatter formatter = DateTimeFormatter.ofPattern("HH:mm:ss" + microSecPattern);
  return dateTime.toLocalDate().toString() + ' ' + dateTime.toLocalTime().format(formatter);
 
- case BLOB:
- case TINYBLOB:
- case MEDIUMBLOB:
- case LONGBLOB:
- if (column.isBinary()) {
- buf.skip(length);
- throw new SQLDataException(
- String.format("Data type %s cannot be decoded as String", column.getType()));
- }
- return buf.readString(length);
-
  default:
  return buf.readString(length);
  }

src/test/java/org/mariadb/jdbc/integration/codec/BlobCodecTest.java

@@ -112,7 +112,7 @@ public void getObjectTypePrepare() throws Exception {
 
  public void getObjectType(ResultSet rs) throws Exception {
  testErrObject(rs, Integer.class);
- testErrObject(rs, String.class);
+ testObject(rs, String.class, "0");
  testErrObject(rs, Long.class);
  testErrObject(rs, Short.class);
  testErrObject(rs, BigDecimal.class);
@@ -151,19 +151,12 @@ public void getStringPrepare() throws SQLException {
  }
 
  public void getString(ResultSet rs) throws SQLException {
- Common.assertThrowsContains(
- SQLDataException.class,
- () -> rs.getNString(1),
- "Data type BLOB cannot be decoded as String");
+ assertEquals("0", rs.getString(1));
  assertFalse(rs.wasNull());
- Common.assertThrowsContains(
- SQLDataException.class,
- () -> rs.getNString(2),
- "Data type BLOB cannot be decoded as String");
- Common.assertThrowsContains(
- SQLDataException.class,
- () -> rs.getNString("t2alias"),
- "Data type BLOB cannot be decoded as String");
+ assertEquals("1", rs.getString(2));
+ assertEquals("1", rs.getString("t2alias"));
+ assertFalse(rs.wasNull());
+ assertEquals("some🌟", rs.getString(3));
  assertFalse(rs.wasNull());
  assertNull(rs.getNString(4));
  assertTrue(rs.wasNull());
@@ -181,19 +174,12 @@ public void getNStringPrepare() throws SQLException {
  }
 
  public void getNString(ResultSet rs) throws SQLException {
- Common.assertThrowsContains(
- SQLDataException.class,
- () -> rs.getNString(1),
- "Data type BLOB cannot be decoded as String");
+ assertEquals("0", rs.getString(1));
  assertFalse(rs.wasNull());
- Common.assertThrowsContains(
- SQLDataException.class,
- () -> rs.getNString(2),
- "Data type BLOB cannot be decoded as String");
- Common.assertThrowsContains(
- SQLDataException.class,
- () -> rs.getNString("t2alias"),
- "Data type BLOB cannot be decoded as String");
+ assertEquals("1", rs.getString(2));
+ assertEquals("1", rs.getString("t2alias"));
+ assertFalse(rs.wasNull());
+ assertEquals("some🌟", rs.getString(3));
  assertFalse(rs.wasNull());
  assertNull(rs.getNString(4));
  assertTrue(rs.wasNull());