Skip to content

Commit ab72818

Browse files
author
diego Dupin
committed
[misc] correcting codecov coverage generation
1 parent d51c2e3 commit ab72818

File tree

4 files changed

+10
-39
lines changed

4 files changed

+10
-39
lines changed

pom.xml

Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<osgi.compendium.version>5.0.0</osgi.compendium.version>
2222
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
2323
<logback.version>1.3.0-alpha10</logback.version>
24-
<jacoco.version>0.8.5</jacoco.version>
24+
<jacoco.version>0.8.7</jacoco.version>
2525
<waffle-jna.version>3.0.0</waffle-jna.version>
2626
<mysql-connector-java.version>8.0.27</mysql-connector-java.version><!--5.1.49-->
2727
</properties>
@@ -243,28 +243,6 @@
243243
<groupId>org.apache.maven.plugins</groupId>
244244
<artifactId>maven-surefire-plugin</artifactId>
245245
<version>3.0.0-M5</version>
246-
<configuration>
247-
<argLine>
248-
--add-reads org.mariadb.jdbc=org.slf4j
249-
--add-reads org.mariadb.jdbc=ch.qos.logback.classic
250-
--add-opens org.mariadb.jdbc/org.mariadb.jdbc.integration=ALL-UNNAMED
251-
--add-opens org.mariadb.jdbc/org.mariadb.jdbc.integration.codec=ALL-UNNAMED
252-
--add-opens org.mariadb.jdbc/org.mariadb.jdbc.integration.resultset=ALL-UNNAMED
253-
--add-opens org.mariadb.jdbc/org.mariadb.jdbc.integration.tools=ALL-UNNAMED
254-
--add-opens org.mariadb.jdbc/org.mariadb.jdbc.unit=ALL-UNNAMED
255-
--add-opens org.mariadb.jdbc/org.mariadb.jdbc.unit.client=ALL-UNNAMED
256-
--add-opens org.mariadb.jdbc/org.mariadb.jdbc.unit.client.result=ALL-UNNAMED
257-
--add-opens org.mariadb.jdbc/org.mariadb.jdbc.unit.client.tls=ALL-UNNAMED
258-
--add-opens org.mariadb.jdbc/org.mariadb.jdbc.unit.plugin=ALL-UNNAMED
259-
--add-opens org.mariadb.jdbc/org.mariadb.jdbc.unit.type=ALL-UNNAMED
260-
--add-opens org.mariadb.jdbc/org.mariadb.jdbc.unit.util=ALL-UNNAMED
261-
--add-opens org.mariadb.jdbc/org.mariadb.jdbc.pool=ALL-UNNAMED
262-
--add-opens org.mariadb.jdbc/org.mariadb.jdbc.unit.util.constant=ALL-UNNAMED
263-
--add-opens org.mariadb.jdbc/org.mariadb.jdbc.unit.util.log=ALL-UNNAMED
264-
--add-reads org.mariadb.jdbc=ALL-UNNAMED
265-
--add-opens=java.base/java.util=ALL-UNNAMED
266-
</argLine>
267-
</configuration>
268246
</plugin>
269247

270248
</plugins>
@@ -350,15 +328,9 @@
350328
<groupId>org.jacoco</groupId>
351329
<artifactId>jacoco-maven-plugin</artifactId>
352330
<version>${jacoco.version}</version>
353-
<configuration>
354-
<destFile>${jacoco.reportPath}</destFile>
355-
<append>true</append>
356-
<excludes>
357-
<exclude>META-INF/**</exclude>
358-
</excludes>
359-
</configuration>
360331
<executions>
361332
<execution>
333+
<id>jacoco-initialize</id>
362334
<goals>
363335
<goal>prepare-agent</goal>
364336
</goals>

src/test/java/org/mariadb/jdbc/integration/BatchTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,10 +164,9 @@ public void differentParameterType(Connection con, boolean expectSuccessUnknown)
164164
assertEquals("2", rs.getString(2));
165165
assertFalse(rs.next());
166166

167-
168167
stmt.execute("TRUNCATE BatchTest");
169168
try (PreparedStatement prep =
170-
con.prepareStatement("INSERT INTO BatchTest(t1, t2) VALUES (?,?)")) {
169+
con.prepareStatement("INSERT INTO BatchTest(t1, t2) VALUES (?,?)")) {
171170
prep.setInt(1, 1);
172171
prep.setInt(2, 1);
173172
prep.addBatch();

src/test/java/org/mariadb/jdbc/integration/FailoverTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,14 +231,15 @@ private void transactionReplayPreparedStatementBatch(
231231
}
232232
}
233233

234-
private void execute(Connection con, boolean transactionReplay, long threadId) throws SQLException {
234+
private void execute(Connection con, boolean transactionReplay, long threadId)
235+
throws SQLException {
235236
Statement stmt = con.createStatement();
236237

237238
stmt.executeUpdate("INSERT INTO transaction_failover_2 (test) VALUES ('test0')");
238239
con.setAutoCommit(false);
239240
stmt.executeUpdate("INSERT INTO transaction_failover_2 (test) VALUES ('test1')");
240241
try (PreparedStatement p =
241-
con.prepareStatement("INSERT INTO transaction_failover_2 (test) VALUES (?)")) {
242+
con.prepareStatement("INSERT INTO transaction_failover_2 (test) VALUES (?)")) {
242243
p.setString(1, "test2");
243244
p.execute();
244245
p.setString(1, "test3");
@@ -280,7 +281,7 @@ private void execute(Connection con, boolean transactionReplay, long threadId) t
280281
con.setAutoCommit(false);
281282
stmt.executeUpdate("INSERT INTO transaction_failover_2 (test) VALUES ('test1')");
282283
try (PreparedStatement p =
283-
con.prepareStatement("INSERT INTO transaction_failover_2 (test) VALUES (?)")) {
284+
con.prepareStatement("INSERT INTO transaction_failover_2 (test) VALUES (?)")) {
284285

285286
proxy.restart(300);
286287
p.setString(1, "test2");

src/test/java/org/mariadb/jdbc/integration/PreparedStatementTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -219,16 +219,15 @@ public void tryMaybeNotPreparable() throws SQLException {
219219
try (PreparedStatement prep = con.prepareStatement("CREATE TABLE maybeCreate(id int)")) {
220220
prep.execute();
221221
}
222-
} finally{
222+
} finally {
223223
sharedConn.createStatement().execute("DROP TABLE IF EXISTS maybeCreate");
224224
}
225225
try (Connection con = createCon("useServerPrepStmts")) {
226226
try (PreparedStatement prep =
227-
con.prepareStatement(
228-
"CREATE PROCEDURE maybeProc(IN I date) BEGIN SELECT I; END")) {
227+
con.prepareStatement("CREATE PROCEDURE maybeProc(IN I date) BEGIN SELECT I; END")) {
229228
prep.execute();
230229
}
231-
} finally{
230+
} finally {
232231
sharedConn.createStatement().execute("DROP PROCEDURE IF EXISTS maybeProc");
233232
}
234233
}

0 commit comments

Comments
 (0)