Skip to content

Commit 5b98d76

Browse files
author
diego Dupin
committed
[test] correcting test for maxscale error MXS-3929
1 parent e06c31e commit 5b98d76

File tree

5 files changed

+37
-8
lines changed

5 files changed

+37
-8
lines changed

src/test/java/org/mariadb/jdbc/integration/LoggingTest.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -102,16 +102,12 @@ void basicLogging() throws Exception {
102102
+ "+--------------------------------------------------+------------------+\n"
103103
+ "| 02 00 00 04 01 31 | .....1 |\n"
104104
+ "+--------------------------------------------------+------------------+\n";
105-
if ("maxscale".equals(System.getenv("srv")) || "skysql-ha".equals(System.getenv("srv"))) {
106105
Assertions.assertTrue(
107-
contents.contains(rowResultWithEof)
108-
|| contents.contains(rowResultWithEof.replace("\r\n", "\n")),
106+
contents.contains(rowResult)
107+
|| contents.contains(rowResult.replace("\r\n", "\n"))
108+
|| contents.contains(rowResultWithEof)
109+
|| contents.contains(rowResultWithEof.replace("\r\n", "\n")),
109110
contents);
110-
} else {
111-
Assertions.assertTrue(
112-
contents.contains(rowResult) || contents.contains(rowResult.replace("\r\n", "\n")),
113-
contents);
114-
}
115111

116112
Assertions.assertTrue(
117113
contents.contains("pool MariaDB-pool new physical connection ")

src/test/java/org/mariadb/jdbc/integration/PreparedStatementTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -652,6 +652,10 @@ public void moreResults() throws SQLException {
652652
}
653653

654654
private void moreResults(Connection con) throws SQLException {
655+
// error MXS-3929 for maxscale 6.2.0
656+
Assumptions.assumeTrue(
657+
!sharedConn.getMetaData().getDatabaseProductVersion().contains("maxScale-6.2.0"));
658+
655659
Assumptions.assumeTrue(isMariaDBServer());
656660
Statement stmt = con.createStatement();
657661
stmt.execute("DROP PROCEDURE IF EXISTS multi");
@@ -713,6 +717,10 @@ public void moreRowLimitedResults() throws SQLException {
713717
}
714718

715719
private void moreRowLimitedResults(Connection con) throws SQLException {
720+
// error MXS-3929 for maxscale 6.2.0
721+
Assumptions.assumeTrue(
722+
!sharedConn.getMetaData().getDatabaseProductVersion().contains("maxScale-6.2.0"));
723+
716724
Statement stmt = con.createStatement();
717725
stmt.execute("DROP PROCEDURE IF EXISTS multi");
718726
stmt.setFetchSize(3);

src/test/java/org/mariadb/jdbc/integration/ProcedureParameterTest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import java.sql.*;
1111
import java.util.BitSet;
1212
import org.junit.jupiter.api.AfterAll;
13+
import org.junit.jupiter.api.Assumptions;
1314
import org.junit.jupiter.api.BeforeAll;
1415
import org.junit.jupiter.api.Test;
1516
import org.mariadb.jdbc.Statement;
@@ -35,6 +36,10 @@ public static void drop() throws SQLException {
3536

3637
@Test
3738
public void callUseParameterName() throws Exception {
39+
// error MXS-3929 for maxscale 6.2.0
40+
Assumptions.assumeTrue(
41+
!sharedConn.getMetaData().getDatabaseProductVersion().contains("maxScale-6.2.0"));
42+
3843
CallableStatement stmt = sharedConn.prepareCall("{call useParameterName(?)}");
3944
stmt.setInt("a", 1);
4045
ResultSet rs = stmt.executeQuery();
@@ -45,6 +50,10 @@ public void callUseParameterName() throws Exception {
4550

4651
@Test
4752
public void callWithStrangeParameter() throws SQLException {
53+
// error MXS-3929 for maxscale 6.2.0
54+
Assumptions.assumeTrue(
55+
!sharedConn.getMetaData().getDatabaseProductVersion().contains("maxScale-6.2.0"));
56+
4857
try (CallableStatement call = sharedConn.prepareCall("{call withStrangeParameter(?)}")) {
4958
double expected = 5.43;
5059
call.setDouble("a", expected);
@@ -65,6 +74,10 @@ public void callWithStrangeParameter() throws SQLException {
6574

6675
@Test
6776
public void basicProcedure() throws SQLException {
77+
// error MXS-3929 for maxscale 6.2.0
78+
Assumptions.assumeTrue(
79+
!sharedConn.getMetaData().getDatabaseProductVersion().contains("maxScale-6.2.0"));
80+
6881
Statement stmt = sharedConn.createStatement();
6982
stmt.execute("DROP PROCEDURE IF EXISTS basic_proc");
7083
stmt.execute(

src/test/java/org/mariadb/jdbc/integration/ProcedureTest.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import java.util.HashMap;
1717
import java.util.Map;
1818
import org.junit.jupiter.api.AfterAll;
19+
import org.junit.jupiter.api.Assumptions;
1920
import org.junit.jupiter.api.BeforeAll;
2021
import org.junit.jupiter.api.Test;
2122
import org.mariadb.jdbc.MariaDbBlob;
@@ -97,6 +98,10 @@ public void prep() throws SQLException {
9798
@Test
9899
@SuppressWarnings("deprecated")
99100
public void basicProcedure() throws Throwable {
101+
// error MXS-3929 for maxscale 6.2.0
102+
Assumptions.assumeTrue(
103+
!sharedConn.getMetaData().getDatabaseProductVersion().contains("maxScale-6.2.0"));
104+
100105
Statement stmt = sharedConn.createStatement();
101106
stmt.execute("DROP PROCEDURE IF EXISTS basic_proc");
102107
stmt.execute(
@@ -458,6 +463,10 @@ private void checkResults(CallableStatement callableStatement) throws SQLExcepti
458463

459464
@Test
460465
public void setProcedureTest() throws Exception {
466+
// error MXS-3929 for maxscale 6.2.0
467+
Assumptions.assumeTrue(
468+
!sharedConn.getMetaData().getDatabaseProductVersion().contains("maxScale-6.2.0"));
469+
461470
Statement stmt = sharedConn.createStatement();
462471
stmt.execute("DROP PROCEDURE IF EXISTS basic_proc");
463472
stmt.execute(

src/test/java/org/mariadb/jdbc/integration/StatementTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -721,6 +721,9 @@ public void fetchSize() throws SQLException {
721721

722722
@Test
723723
public void moreResults() throws SQLException {
724+
// error MXS-3929 for maxscale 6.2.0
725+
Assumptions.assumeTrue(
726+
!sharedConn.getMetaData().getDatabaseProductVersion().contains("maxScale-6.2.0"));
724727
Assumptions.assumeTrue(isMariaDBServer());
725728
Statement stmt = sharedConn.createStatement();
726729
stmt.execute("DROP PROCEDURE IF EXISTS multi");

0 commit comments

Comments
 (0)