[CONJ-1112] code style validation change

library com.spotify.fmt:fmt-maven-plugin is not compatible with java 21, replaced by com.theoryinpractise:googleformatter-maven-plugin

Author: rusher

CHANGELOG.md

@@ -1,70 +1,80 @@
 # Contributing
 
-Each pull request should address a single issue, and contain both the fix and a description of how the pull request and tests that validate that the PR fixes the issue in question.
+Each pull request should address a single issue, and contain both the fix and a description of how the pull request and
+tests that validate that the PR fixes the issue in question.
 
-For significant feature additions, we like to have an open issue in [MariaDB JIRA](https://mariadb.atlassian.net/secure/RapidBoard.jspa?projectKey=CONJ). It is expected that discussion will have taken place in the attached issue.
+For significant feature additions, we like to have an open issue
+in [MariaDB JIRA](https://mariadb.atlassian.net/secure/RapidBoard.jspa?projectKey=CONJ). It is expected that discussion
+will have taken place in the attached issue.
 
 # Install Prerequisites
 
-These are the set of tools which are required in order to complete any build. Follow the links to download and install them on your own before continuing.
+These are the set of tools which are required in order to complete any build. Follow the links to download and install
+them on your own before continuing.
 
 * At least one GPG Key see https://help.github.com/en/articles/generating-a-new-gpg-key
-* [Oracle JDK 8](http://www.oracle.com/technetwork/java/javase/downloads/index.html) ( with [JCE policies](http://www.oracle.com/technetwork/java/javase/downloads/jce8-download-2133166.html) if using TLS/SSL)
+* [Oracle JDK 8](http://www.oracle.com/technetwork/java/javase/downloads/index.html) (
+ with [JCE policies](http://www.oracle.com/technetwork/java/javase/downloads/jce8-download-2133166.html) if using
+ TLS/SSL)
 * IDE (eclipse / netbean / intelliJ) with maven and GIT plugins
 
 # Fork source
 
-Before downloading source, fork the project to your own repository, and use your repository as source. 
+Before downloading source, fork the project to your own repository, and use your repository as source.
 
 ## Branch signification
 
 * master : correspond to the last released version
 * develop : Develop new features for upcoming releases (compatible with java 8)
-* develop-jre6 : maintenance branch compatible with java 6 / 7 
+* develop-jre6 : maintenance branch compatible with java 6 / 7
 
 # Run local test
 
 Before any submission :
-Run the test locally : by default, you need to have a MySQL/MariaDB server on localhost:3306 with a database named "testj" and a user root without password.
-so you can run 
- 
+Run the test locally : by default, you need to have a MySQL/MariaDB server on localhost:3306 with a database named "
+testj" and a user root without password.
+so you can run
+
 ```script
  mvn test
 ```
- 
-You can change this parameter by adding -DdbUrl parameter. like : 
- 
+
+You can change this parameter by adding -DdbUrl parameter. like :
+
 ```script
  mvn test -DdbUrl=jdbc:mariadb://127.0.0.1:3306/testj?user=root&password=*****
 ```
- 
+
 You can launch a specific test by adding -Dtest
 
 ```script
  mvn test -Dtest=org.mariadb.jdbc.JdbcParserTest
 ```
- 
+
 When all test are passing, you can package project.
-Additional tests , like javadoc formatting, code style validation will be done : 
- 
+Additional tests , like javadoc formatting, code style validation will be done :
+
 ```script
  mvn package -Dmaven.test.skip=true
 ```
- 
+
 If operation succeed, a new mariadb-java-client jar will be on the target folder.
- 
+
 # Run travis test
- 
-You can activate travis to validate your repository. 
-The advantage of travis compare to running test locally is that it will launch tests for a combination of those parameters : 
+
+You can activate travis to validate your repository.
+The advantage of travis compare to running test locally is that it will launch tests for a combination of those
+parameters :
 
 jdk:
+
 * oraclejdk8
-and if your work is on develop-jre6 branch
+ and if your work is on develop-jre6 branch
 * openjdk6
 * openjdk7
 
 server :
+
 * MariaDB 5.5
 * MariaDB 10.0
 * MariaDB 10.1
@@ -73,17 +83,20 @@ server :
 * MySQL 5.7
 
 max_allowed_packet : (this permit to check multipacket send)
+
 * 8M
 * 20M
 * 40M
 
-For that, you have to go on [travis website](https://travis-ci.org), connect with your github account, and activate your mariadb-connector-j repository.
-After this step, every push to your repository will launch a travis test. 
+For that, you have to go on [travis website](https://travis-ci.org), connect with your github account, and activate your
+mariadb-connector-j repository.
+After this step, every push to your repository will launch a travis test.
 
 ## Submitting a request
 
-When your repository has the correction/change done, you can submit a pull request by clicking the "Pull request" button on github. 
-Please detail the operation done in your request. 
+When your repository has the correction/change done, you can submit a pull request by clicking the "Pull request" button
+on github.
+Please detail the operation done in your request.
 
 ## License
 

CONTRIBUTING.md

@@ -1,16 +1,18 @@
-<p align="center">
+<p style="text-align: center;">
  <a href="https://mariadb.com/">
- <img src="https://mariadb.com/kb/static/images/logo-2018-black.png">
+ <img alt="mariadb logo" src="https://mariadb.com/kb/static/images/logo-2018-black.png">
  </a>
 </p>
 
 # MariaDB java connector
 
-MariaDB java connector is a JDBC 4.2 compatible driver, used to connect applications developed in Java to MariaDB and MySQL databases. MariaDB Connector/J is LGPL licensed.
+MariaDB java connector is a JDBC 4.2 compatible driver, used to connect applications developed in Java to MariaDB and
+MySQL databases. MariaDB Connector/J is LGPL licensed.
 
 Tracker link <a href="https://jira.mariadb.org/projects/CONJ/issues/">https://jira.mariadb.org/projects/CONJ/issues/</a>
 
 ## Status
+
 [![Linux Build](https://travis-ci.com/mariadb-corporation/mariadb-connector-j.svg?branch=master)](https://app.travis-ci.com/github/mariadb-corporation/mariadb-connector-j)
 [![Maven Central](https://maven-badges.herokuapp.com/maven-central/org.mariadb.jdbc/mariadb-java-client/badge.svg)](https://maven-badges.herokuapp.com/maven-central/org.mariadb.jdbc/mariadb-java-client)
 [![License (LGPL version 2.1)](https://img.shields.io/badge/license-GNU%20LGPL%20version%202.1-green.svg?style=flat-square)](http://opensource.org/licenses/LGPL-2.1)
@@ -21,7 +23,8 @@ Tracker link <a href="https://jira.mariadb.org/projects/CONJ/issues/">https://ji
 For java 8+ :
 
 The driver (jar) can be downloaded from [mariadb connector download](https://mariadb.com/downloads/#connectors)
-or maven : 
+or maven :
+
 ```script
 <dependency>
 <groupId>org.mariadb.jdbc</groupId>
@@ -30,8 +33,8 @@ or maven :
 </dependency>
 ```
 
-
 Development snapshot are available on sonatype nexus repository
+
 ```script
 <repositories>
  <repository>
@@ -52,12 +55,13 @@ Development snapshot are available on sonatype nexus repository
 
 ## Documentation
 
-For a Getting started guide, API docs, recipes, etc. see the 
+For a Getting started guide, API docs, recipes, etc. see the
+
 * [About MariaDB connector/J](https://mariadb.com/kb/en/about-mariadb-connector-j/)
 * [Install driver](https://mariadb.com/kb/en/installing-mariadb-connectorj/)
 * [Changelog](/CHANGELOG.md)
 * [Failover and high-availability](https://mariadb.com/kb/en/failover-and-high-availability-with-mariadb-connector-j/)
 
-
 [codecov-image]:https://codecov.io/gh/mariadb-corporation/mariadb-connector-j/branch/master/graph/badge.svg
+
 [codecov-url]:https://codecov.io/gh/mariadb-corporation/mariadb-connector-j

README.md

@@ -231,20 +231,30 @@
  </execution>
  </executions>
  </plugin>
-
  <plugin>
- <groupId>com.spotify.fmt</groupId>
- <artifactId>fmt-maven-plugin</artifactId>
- <version>2.20</version>
+ <groupId>com.theoryinpractise</groupId>
+ <artifactId>googleformatter-maven-plugin</artifactId>
+ <version>1.7.3</version>
  <executions>
  <execution>
+ <id>reformat-sources</id>
+ <configuration>
+ <includeStale>false</includeStale>
+ <style>GOOGLE</style>
+ <formatMain>true</formatMain>
+ <formatTest>true</formatTest>
+ <filterModified>false</filterModified>
+ <skip>false</skip>
+ <fixImports>false</fixImports>
+ <maxLineLength>100</maxLineLength>
+ </configuration>
  <goals>
  <goal>format</goal>
  </goals>
+ <phase>process-sources</phase>
  </execution>
  </executions>
  </plugin>
-
  <plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-surefire-plugin</artifactId>

pom.xml

@@ -1,12 +1,13 @@
-<p align="center">
+<p style="text-align: center;">
  <a href="https://mariadb.com/">
- <img src="https://mariadb.com/kb/static/images/logo-2018-black.png">
+ <img alt="mariadb logo" src="https://mariadb.com/kb/static/images/logo-2018-black.png">
  </a>
 </p>
 
 # Benchmark
 
-How to run : 
+How to run :
+
 ```script
 mvn clean package -P bench -DskipTests
 
@@ -18,14 +19,16 @@ java -Duser.country=US -Duser.language=en -jar target/benchmarks.jar "Select_100
 ```
 
 Configuration by system properties :
+
 * TEST_HOST: Hostname. default "localhost"
 * TEST_PORT: port. default 3306
 * TEST_USERNAME: user name. default "root"
 * TEST_PASSWORD: password. default ""
 * TEST_DATABASE: database. default "testj"
 * TEST_OTHER: permit adding connection string options. default ""
 
-example: 
+example:
+
 ```script
 mvn clean package -P bench -Dmaven.test.skip
 java -DTEST_PORT=3307 -Duser.country=US -Duser.language=en -jar target/benchmarks.jar "Select_100_cols"

src/benchmark/README.md

@@ -4,14 +4,13 @@
 
 package org.mariadb.jdbc;
 
-import org.openjdk.jmh.annotations.*;
-
 import java.sql.Connection;
 import java.sql.DriverManager;
 import java.sql.SQLException;
 import java.sql.Statement;
 import java.util.Properties;
 import java.util.concurrent.TimeUnit;
+import org.openjdk.jmh.annotations.*;
 
 @State(Scope.Benchmark)
 @Warmup(iterations = 10, timeUnit = TimeUnit.SECONDS, time = 1)

src/benchmark/java/org/mariadb/jdbc/Common.java

@@ -11,11 +11,10 @@
 
 public class Do_1 extends Common {
 
- @Benchmark
- public int run(MyState state) throws Throwable {
- try (Statement st = state.connectionText.createStatement()) {
- return st.executeUpdate("DO 1");
- }
+ @Benchmark
+ public int run(MyState state) throws Throwable {
+ try (Statement st = state.connectionText.createStatement()) {
+ return st.executeUpdate("DO 1");
  }
-
+ }
 }

src/benchmark/java/org/mariadb/jdbc/Do_1.java

@@ -4,11 +4,9 @@
 
 package org.mariadb.jdbc;
 
-import org.openjdk.jmh.annotations.Benchmark;
-
 import java.sql.Connection;
 import java.sql.PreparedStatement;
-import java.sql.ResultSet;
+import org.openjdk.jmh.annotations.Benchmark;
 
 public class Do_1000_params extends Common {
 

src/benchmark/java/org/mariadb/jdbc/Do_1000_params.java

@@ -4,15 +4,12 @@
 
 package org.mariadb.jdbc;
 
-import org.openjdk.jmh.annotations.Benchmark;
-
 import java.sql.Connection;
 import java.sql.PreparedStatement;
-import java.sql.ResultSet;
-import java.sql.Statement;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
+import org.openjdk.jmh.annotations.Benchmark;
 
 public class Insert_batch extends Common {
 

src/benchmark/java/org/mariadb/jdbc/Insert_batch.java

@@ -4,10 +4,9 @@
 
 package org.mariadb.jdbc;
 
-import org.openjdk.jmh.annotations.Benchmark;
-
 import java.sql.ResultSet;
 import java.sql.Statement;
+import org.openjdk.jmh.annotations.Benchmark;
 
 public class Select_1 extends Common {