Skip to content

Commit 075342a

Browse files
author
diego Dupin
committed
[misc] ensuring test reliability on Skysql HA
1 parent 6817862 commit 075342a

27 files changed

+243
-107
lines changed

src/test/java/org/mariadb/jdbc/integration/codec/BinaryCodecTest.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,22 +50,27 @@ public static void beforeAll2() throws SQLException {
5050

5151
private ResultSet get() throws SQLException {
5252
Statement stmt = sharedConn.createStatement();
53+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
5354
ResultSet rs =
5455
stmt.executeQuery(
5556
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from BinaryCodec");
5657
assertTrue(rs.next());
58+
sharedConn.commit();
5759
return rs;
5860
}
5961

6062
private ResultSet getPrepare(Connection con) throws SQLException {
61-
PreparedStatement stmt =
63+
java.sql.Statement stmt = con.createStatement();
64+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
65+
PreparedStatement prepareStatement =
6266
con.prepareStatement(
6367
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from BinaryCodec"
6468
+ " WHERE 1 > ?");
65-
stmt.closeOnCompletion();
66-
stmt.setInt(1, 0);
67-
ResultSet rs = stmt.executeQuery();
69+
prepareStatement.closeOnCompletion();
70+
prepareStatement.setInt(1, 0);
71+
ResultSet rs = prepareStatement.executeQuery();
6872
assertTrue(rs.next());
73+
con.commit();
6974
return rs;
7075
}
7176

src/test/java/org/mariadb/jdbc/integration/codec/BitCodecTest.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,22 +40,27 @@ public static void beforeAll2() throws SQLException {
4040

4141
private ResultSet get() throws SQLException {
4242
Statement stmt = sharedConn.createStatement();
43+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
4344
ResultSet rs =
4445
stmt.executeQuery(
4546
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from BitCodec");
4647
assertTrue(rs.next());
48+
sharedConn.commit();
4749
return rs;
4850
}
4951

5052
private ResultSet getPrepare(Connection con) throws SQLException {
51-
PreparedStatement stmt =
53+
java.sql.Statement stmt = con.createStatement();
54+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
55+
PreparedStatement preparedStatement =
5256
con.prepareStatement(
5357
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from BitCodec"
5458
+ " WHERE 1 > ?");
55-
stmt.closeOnCompletion();
56-
stmt.setInt(1, 0);
57-
ResultSet rs = stmt.executeQuery();
59+
preparedStatement.closeOnCompletion();
60+
preparedStatement.setInt(1, 0);
61+
ResultSet rs = preparedStatement.executeQuery();
5862
assertTrue(rs.next());
63+
con.commit();
5964
return rs;
6065
}
6166

src/test/java/org/mariadb/jdbc/integration/codec/BlobCodecTest.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ public static void beforeAll2() throws Exception {
5656

5757
private ResultSet get() throws SQLException {
5858
Statement stmt = sharedConn.createStatement();
59+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
5960
ResultSet rs =
6061
stmt.executeQuery(
6162
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from BlobCodec");
@@ -64,14 +65,17 @@ private ResultSet get() throws SQLException {
6465
}
6566

6667
private CompleteResult getPrepare(org.mariadb.jdbc.Connection con) throws SQLException {
67-
PreparedStatement stmt =
68+
java.sql.Statement stmt = con.createStatement();
69+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
70+
PreparedStatement preparedStatement =
6871
con.prepareStatement(
6972
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from BlobCodec"
7073
+ " WHERE 1 > ?");
71-
stmt.closeOnCompletion();
72-
stmt.setInt(1, 0);
73-
CompleteResult rs = (CompleteResult) stmt.executeQuery();
74+
preparedStatement.closeOnCompletion();
75+
preparedStatement.setInt(1, 0);
76+
CompleteResult rs = (CompleteResult) preparedStatement.executeQuery();
7477
assertTrue(rs.next());
78+
con.commit();
7579
return rs;
7680
}
7781

src/test/java/org/mariadb/jdbc/integration/codec/CharCodecTest.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,22 +46,27 @@ public static void beforeAll2() throws SQLException {
4646

4747
private ResultSet get() throws SQLException {
4848
Statement stmt = sharedConn.createStatement();
49+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
4950
ResultSet rs =
5051
stmt.executeQuery(
5152
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from CharCodec");
5253
assertTrue(rs.next());
54+
sharedConn.commit();
5355
return rs;
5456
}
5557

5658
private ResultSet getPrepare(Connection con) throws SQLException {
57-
PreparedStatement stmt =
59+
java.sql.Statement stmt = con.createStatement();
60+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
61+
PreparedStatement preparedStatement =
5862
con.prepareStatement(
5963
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from CharCodec"
6064
+ " WHERE 1 > ?");
61-
stmt.closeOnCompletion();
62-
stmt.setInt(1, 0);
63-
ResultSet rs = stmt.executeQuery();
65+
preparedStatement.closeOnCompletion();
66+
preparedStatement.setInt(1, 0);
67+
ResultSet rs = preparedStatement.executeQuery();
6468
assertTrue(rs.next());
69+
con.commit();
6570
return rs;
6671
}
6772

src/test/java/org/mariadb/jdbc/integration/codec/ClobCodecTest.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,22 +51,27 @@ public static void beforeAll2() throws SQLException {
5151

5252
private ResultSet get() throws SQLException {
5353
Statement stmt = sharedConn.createStatement();
54+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
5455
ResultSet rs =
5556
stmt.executeQuery(
5657
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from ClobCodec");
5758
assertTrue(rs.next());
59+
sharedConn.commit();
5860
return rs;
5961
}
6062

6163
private ResultSet getPrepare(Connection con) throws SQLException {
62-
PreparedStatement stmt =
64+
java.sql.Statement stmt = con.createStatement();
65+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
66+
PreparedStatement preparedStatement =
6367
con.prepareStatement(
6468
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from ClobCodec"
6569
+ " WHERE 1 > ?");
66-
stmt.closeOnCompletion();
67-
stmt.setInt(1, 0);
68-
ResultSet rs = stmt.executeQuery();
70+
preparedStatement.closeOnCompletion();
71+
preparedStatement.setInt(1, 0);
72+
ResultSet rs = preparedStatement.executeQuery();
6973
assertTrue(rs.next());
74+
con.commit();
7075
return rs;
7176
}
7277

src/test/java/org/mariadb/jdbc/integration/codec/DateCodecTest.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,22 +42,27 @@ public static void beforeAll2() throws SQLException {
4242

4343
private ResultSet get() throws SQLException {
4444
Statement stmt = sharedConn.createStatement();
45+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
4546
ResultSet rs =
4647
stmt.executeQuery(
4748
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from DateCodec");
4849
assertTrue(rs.next());
50+
sharedConn.commit();
4951
return rs;
5052
}
5153

5254
private ResultSet getPrepare(Connection con) throws SQLException {
53-
PreparedStatement stmt =
55+
java.sql.Statement stmt = con.createStatement();
56+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
57+
PreparedStatement preparedStatement =
5458
con.prepareStatement(
5559
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from DateCodec"
5660
+ " WHERE 1 > ?");
57-
stmt.closeOnCompletion();
58-
stmt.setInt(1, 0);
59-
ResultSet rs = stmt.executeQuery();
61+
preparedStatement.closeOnCompletion();
62+
preparedStatement.setInt(1, 0);
63+
ResultSet rs = preparedStatement.executeQuery();
6064
assertTrue(rs.next());
65+
con.commit();
6166
return rs;
6267
}
6368

src/test/java/org/mariadb/jdbc/integration/codec/DateTimeCodecTest.java

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,22 +48,27 @@ public static void beforeAll2() throws SQLException {
4848

4949
private ResultSet get() throws SQLException {
5050
Statement stmt = sharedConn.createStatement();
51+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
5152
ResultSet rs =
5253
stmt.executeQuery(
5354
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from DateTimeCodec");
5455
assertTrue(rs.next());
56+
sharedConn.commit();
5557
return rs;
5658
}
5759

5860
private ResultSet getPrepare(Connection con) throws SQLException {
59-
PreparedStatement stmt =
61+
java.sql.Statement stmt = con.createStatement();
62+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
63+
PreparedStatement prepStmt =
6064
con.prepareStatement(
6165
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from DateTimeCodec"
6266
+ " WHERE 1 > ?");
63-
stmt.closeOnCompletion();
64-
stmt.setInt(1, 0);
65-
ResultSet rs = stmt.executeQuery();
67+
prepStmt.closeOnCompletion();
68+
prepStmt.setInt(1, 0);
69+
ResultSet rs = prepStmt.executeQuery();
6670
assertTrue(rs.next());
71+
con.commit();
6772
return rs;
6873
}
6974

@@ -76,6 +81,7 @@ public void getObject() throws SQLException {
7681
public void getObjectPrepare() throws SQLException {
7782
getObject(getPrepare(sharedConn));
7883
getObject(getPrepare(sharedConnBinary));
84+
7985
}
8086

8187
public void getObject(ResultSet rs) throws SQLException {

src/test/java/org/mariadb/jdbc/integration/codec/DecimalCodecTest.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,22 +43,27 @@ public static void beforeAll2() throws SQLException {
4343

4444
private ResultSet get() throws SQLException {
4545
Statement stmt = sharedConn.createStatement();
46+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
4647
ResultSet rs =
4748
stmt.executeQuery(
4849
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from DecimalCodec");
4950
assertTrue(rs.next());
51+
sharedConn.commit();
5052
return rs;
5153
}
5254

5355
private ResultSet getPrepare(Connection con) throws SQLException {
54-
PreparedStatement stmt =
56+
java.sql.Statement stmt = con.createStatement();
57+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
58+
PreparedStatement preparedStatement =
5559
con.prepareStatement(
5660
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from DecimalCodec"
5761
+ " WHERE 1 > ?");
58-
stmt.closeOnCompletion();
59-
stmt.setInt(1, 0);
60-
ResultSet rs = stmt.executeQuery();
62+
preparedStatement.closeOnCompletion();
63+
preparedStatement.setInt(1, 0);
64+
ResultSet rs = preparedStatement.executeQuery();
6165
assertTrue(rs.next());
66+
con.commit();
6267
return rs;
6368
}
6469

src/test/java/org/mariadb/jdbc/integration/codec/DoubleCodecTest.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,22 +39,27 @@ public static void beforeAll2() throws SQLException {
3939

4040
private ResultSet get() throws SQLException {
4141
Statement stmt = sharedConn.createStatement();
42+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
4243
ResultSet rs =
4344
stmt.executeQuery(
4445
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from DoubleCodec");
4546
assertTrue(rs.next());
47+
sharedConn.commit();
4648
return rs;
4749
}
4850

4951
private ResultSet getPrepare(Connection con) throws SQLException {
50-
PreparedStatement stmt =
52+
java.sql.Statement stmt = con.createStatement();
53+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
54+
PreparedStatement preparedStatement =
5155
con.prepareStatement(
5256
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from DoubleCodec"
5357
+ " WHERE 1 > ?");
54-
stmt.closeOnCompletion();
55-
stmt.setInt(1, 0);
56-
ResultSet rs = stmt.executeQuery();
58+
preparedStatement.closeOnCompletion();
59+
preparedStatement.setInt(1, 0);
60+
ResultSet rs = preparedStatement.executeQuery();
5761
assertTrue(rs.next());
62+
con.commit();
5863
return rs;
5964
}
6065

src/test/java/org/mariadb/jdbc/integration/codec/EnumCodecTest.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,22 +49,27 @@ public static void beforeAll2() throws SQLException {
4949

5050
private ResultSet get() throws SQLException {
5151
Statement stmt = sharedConn.createStatement();
52+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
5253
ResultSet rs =
5354
stmt.executeQuery(
5455
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from EnumCodec");
5556
assertTrue(rs.next());
57+
sharedConn.commit();
5658
return rs;
5759
}
5860

5961
private ResultSet getPrepare(Connection con) throws SQLException {
60-
PreparedStatement stmt =
62+
java.sql.Statement stmt = con.createStatement();
63+
stmt.execute("START TRANSACTION"); // if MAXSCALE ensure using WRITER
64+
PreparedStatement preparedStatement =
6165
con.prepareStatement(
6266
"select t1 as t1alias, t2 as t2alias, t3 as t3alias, t4 as t4alias from EnumCodec"
6367
+ " WHERE 1 > ?");
64-
stmt.closeOnCompletion();
65-
stmt.setInt(1, 0);
66-
ResultSet rs = stmt.executeQuery();
68+
preparedStatement.closeOnCompletion();
69+
preparedStatement.setInt(1, 0);
70+
ResultSet rs = preparedStatement.executeQuery();
6771
assertTrue(rs.next());
72+
con.commit();
6873
return rs;
6974
}
7075

0 commit comments

Comments
 (0)