[misc] prepareStatement.addBatch must initialize with previous set

Author: diego Dupin

src/main/java/org/mariadb/jdbc/ClientPreparedStatement.java

@@ -319,7 +319,7 @@ public void addBatch() throws SQLException {
  validParameters();
  if (batchParameters == null) batchParameters = new ArrayList<>();
  batchParameters.add(parameters);
- parameters = new ParameterList();
+ parameters = parameters.clone();
  }
 
  protected void validParameters() throws SQLException {

src/main/java/org/mariadb/jdbc/ServerPreparedStatement.java

@@ -461,7 +461,7 @@ public void addBatch() throws SQLException {
  validParameters();
  if (batchParameters == null) batchParameters = new ArrayList<>();
  batchParameters.add(parameters);
- parameters = new ParameterList(parameters.size());
+ parameters = parameters.clone();
  }
 
  protected void validParameters() throws SQLException {

src/main/java/org/mariadb/jdbc/util/ParameterList.java

@@ -36,9 +36,9 @@ public boolean containsKey(int index) {
  }
 
  public void set(int index, Parameter element) {
- if (elementData.length < index + 1) grow(index + 1);
+ if (elementData.length <= index) grow(index + 1);
  elementData[index] = element;
- if (index + 1 > length) length = index + 1;
+ if (index >= length) length = index + 1;
  }
 
  public int size() {
@@ -54,7 +54,7 @@ private void grow(int minLength) {
  @Override
  public ParameterList clone() {
  ParameterList param = new ParameterList(length);
- if (length >= 0) System.arraycopy(elementData, 0, param.elementData, 0, length);
+ if (length > 0) System.arraycopy(elementData, 0, param.elementData, 0, length);
  param.length = length;
  return param;
  }

src/test/java/org/mariadb/jdbc/integration/BatchTest.java

@@ -68,10 +68,7 @@ public void wrongParameter(Connection con) throws SQLException {
  prep.setString(2, "ok");
  prep.addBatch();
  prep.setString(2, "without position 1");
- Common.assertThrowsContains(
- SQLTransientConnectionException.class,
- prep::addBatch,
- "Parameter at " + "position 1 is not set");
+ prep.addBatch();
  }
  }