Always access navigator via window

snowplow#1285

Author: jethron

common/changes/@snowplow/browser-tracker-core/navigator-access_2024-01-25-03-04.json

@@ -0,0 +1,10 @@
+{
+ "changes": [
+ {
+ "packageName": "@snowplow/browser-tracker-core",
+ "comment": "Consistently access navigator via window.navigator",
+ "type": "none"
+ }
+ ],
+ "packageName": "@snowplow/browser-tracker-core"
+}

libraries/browser-tracker-core/src/helpers/browser_props.ts

@@ -10,7 +10,7 @@ export function getBrowserProperties() {
  devicePixelRatio: window.devicePixelRatio,
  cookiesEnabled: window.navigator.cookieEnabled,
  online: window.navigator.onLine,
- browserLanguage: navigator.language || (navigator as any).userLanguage,
+ browserLanguage: window.navigator.language || (window.navigator as any).userLanguage,
  documentLanguage: document.documentElement.lang,
  webdriver: window.navigator.webdriver,
  deviceMemory: (window.navigator as any).deviceMemory,

libraries/browser-tracker-core/src/tracker/index.ts

@@ -228,7 +228,7 @@ export function Tracker(
  // First-party cookie secure attribute
  configCookieSecure = trackerConfiguration.cookieSecure ?? true,
  // Do Not Track browser feature
- dnt = navigator.doNotTrack || navigator.msDoNotTrack || window.doNotTrack,
+ dnt = window.navigator.doNotTrack || window.navigator.msDoNotTrack || window.doNotTrack,
  // Do Not Track
  configDoNotTrack =
  typeof trackerConfiguration.respectDoNotTrack !== 'undefined'

libraries/browser-tracker-core/src/tracker/out_queue.ts

@@ -81,7 +81,7 @@ export function OutQueueManager(
  isBeaconAvailable = Boolean(
  isBeaconRequested &&
  window.navigator &&
- window.navigator.sendBeacon &&
+ typeof window.navigator.sendBeacon === 'function' &&
  !hasWebKitBeaconBug(window.navigator.userAgent)
  ),
  useBeacon = isBeaconAvailable && isBeaconRequested,
@@ -412,7 +412,7 @@ export function OutQueueManager(
  type: 'application/json',
  });
  try {
- beaconStatus = navigator.sendBeacon(url, blob);
+ beaconStatus = window.navigator.sendBeacon(url, blob);
  } catch (error) {
  beaconStatus = false;
  }